webpack-hot-client icon indicating copy to clipboard operation
webpack-hot-client copied to clipboard

Published 20 hours ago • verified publisher icon webpack-contrib

fix(index): correctly pass args to `stats.toJson` and cache `stats`

Open kamijin-fanta opened this issue 7 years ago • 4 comments

This PR contains a:

  • [x] bugfix
  • [ ] new feature
  • [x] code refactor
  • [ ] test update
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

  • options.stats was not used (it was overwritten)
  • cached results of heavy stats.toJson

Breaking Changes

none

Additional Info

none

kamijin-fanta avatar Aug 01 '18 04:08 kamijin-fanta

CLA assistant check
All committers have signed the CLA.

jsf-clabot avatar Aug 01 '18 04:08 jsf-clabot

@michael-ciniawsky what is the status of this PR?

kamijin-fanta avatar Nov 16 '18 01:11 kamijin-fanta

This code is merged in https://github.com/hedgepigdaniel/webpack-hmr-client

hedgepigdaniel avatar Oct 03 '19 07:10 hedgepigdaniel

This PR is really valuable and allows to save around 1s on hot reload in large projects. @shellscape @michael-ciniawsky what needs to be done to merge it?

gbiryukov avatar Oct 10 '19 07:10 gbiryukov