webpack-hot-client icon indicating copy to clipboard operation
webpack-hot-client copied to clipboard

Published 20 hours ago • verified publisher icon webpack-contrib

feat: add option to set client/server port seperatly for sockets

Open DBosley opened this issue 7 years ago • 4 comments

This PR contains a:

  • [ ] bugfix
  • [x] new feature
  • [ ] code refactor
  • [ ] test update
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

Fixes #79. Adds server/client configuration for the websocket port.

Breaking Changes

Additional Info

DBosley avatar Jun 25 '18 18:06 DBosley

CLA assistant check
All committers have signed the CLA.

jsf-clabot avatar Jun 25 '18 18:06 jsf-clabot

Thanks for the PR :beer:

Really appreciate your efforts here. But it may have been premature before we've had the chance to discuss the proposal in #79.

shellscape avatar Jun 25 '18 18:06 shellscape

That's entirely fine. This issue was blocking me locally so I wanted to test out the idea. I had some spare time so I figured I'd fork it and give it a shot. If there are changes you'd like to make to the proposal or the PR, or if you don't think the idea's worth adding we can go from there.

DBosley avatar Jun 25 '18 18:06 DBosley

👍 Let's discuss on the issue you created.

shellscape avatar Jun 25 '18 19:06 shellscape