webpack-bundle-analyzer icon indicating copy to clipboard operation
webpack-bundle-analyzer copied to clipboard

Published 20 hours ago • verified publisher icon webpack-contrib

Reduce the usage of lodash

Open SukkaW opened this issue 2 years ago • 1 comments

Why do we need lodash if we can utilize features provided by the ECMAScript itself :)

SukkaW avatar Mar 31 '22 17:03 SukkaW

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: SukkaW / name: Sukka (f5bd533197edce4d3b4c6f06494a151b1ed799b7, 3ca725f16f3860aea44f2fdab3e9ada4a9aaee44, 56de02537b70718f3b2a1be930a66cbf4a568cd9, 33f7df1e28b347bcd2e86d5d31d9043ba22f7811, d2916cb980e84616150e405955cb0a87e09ee67c, aba7a57e863b19383b587f9437899acd4a8cfe9b, 867e2762401baf6ec776e54758253a74ab6f1f1d, f162c20b5cc5beee362ae01f9cdf6b8618114411, ead9a9b729905e97975808d74283b4545f477c03)

linux-foundation-easycla[bot] avatar Mar 31 '22 17:03 linux-foundation-easycla[bot]

Looks like some tests are breaking. Have you tried if running tests locally pass for you?

valscion avatar Aug 01 '23 06:08 valscion

Looks like some tests are breaking. Have you tried if running tests locally pass for you?

Yeah, I have been looking into this. However, it only shows timeout (instead of test mismatch) on my side.

Update: @valscion I have fixed all failed test cases found on my machine.

SukkaW avatar Aug 01 '23 13:08 SukkaW

Looks like there are still some test failures only found in this PR and also lint errors.

valscion avatar Aug 02 '23 07:08 valscion

Looks like there are still some test failures only found in this PR and also lint errors.

Fixed the viewer.js test in f162c20 (#505) and fix lint errors from npm run lint in ead9a9b (#505).

SukkaW avatar Aug 02 '23 12:08 SukkaW

Thanks, looks good to me! The diff is small enough that it seems like it shouldn't cause any regressions.

This doesn't look like it needs to be urgently released so I'll give it some time until there are other things that warrant a new release ☺️

And I am planning more PRs (that I want to be included in the next release) as well.

SukkaW avatar Aug 02 '23 13:08 SukkaW