webpack-bundle-analyzer
webpack-bundle-analyzer copied to clipboard
webpack-contrib
plugin use infrastructureLogger and output the report.html to compiler.outputFileSystem
I hope you won't get discouraged by the dev-server tests hanging when running in GitHub actions CI 😓.
I spent a great deal of time in figuring out why the dev-server related tests were always hanging in CI and not on my own machine and the only fix that seemed to work was this one: 55f3478dbb8036d403ad5cd8b128ef4c58ef3417. If you check 36e960bac9010e4eb71947ba7091d6e70093a408 and the commits leading up to it, you can see my failed attempts at figuring out different alternatives which just didn't seem to work in CI.
If you manage to get the tests to not hang in CI, that would be amazing. I had a pretty bad time debugging those failures myself.
I cancelled the workflow run now as it was hanging.
@valscion. I think the hanging up issue is because the second expect is failed. Then it stops executing the rest. If it can execute to the end, it will not hang up and finish quickly.
Even with classic function (done) it will still block from executing to the end if one of the expect is failed. Then it will still leave the never ended server. Jest cannot exit
@wood1986 may I kindly ask you to:
- Fix PR review issues in a separate commits and don't use force-push as it's really difficult to track changes you've made
- Don't resolve my comments - I would like to do this myself.
@wood1986 may I kindly ask you to:
- Fix PR review issues in a separate commits and don't use force-push as it's really difficult to track changes you've made
- Don't resolve my comments - I would like to do this myself.
No problem
- I thought this is a very tiny and it should be very quick to check all the check again
- I usually use the resolve to let comment owner know I have completed. Meanwhile it will be easy for me to see what things left.
I will do what you ask
