svg-inline-loader icon indicating copy to clipboard operation
svg-inline-loader copied to clipboard

refactor: Webpack 4.x compatibility

Open joshwiens opened this issue 7 years ago β€’ 22 comments

Compatibility issues
  • [ ] N/A
Commit message body
 - Updates code style to Prettier
 - Updates engines
 - Updates peerDependencies
 - Enforces commit message formatting
 - Migrates to CircleCI 2.0
 - Removes deprecated React JSX support

BREAKING CHANGE: Drops support for NodeJS 4.x

BREAKING CHANGE: Drops support for Webpack 2.x

BREAKING CHANGE: `loaderUtils.getOptions()` is not backwards compatible

BREAKING CHANGE: JSX Support was deprecated in `v0.4.0` Please use [svg-inline-react](https://www.npmjs.com/package/svg-inline-react) package

joshwiens avatar Dec 21 '17 07:12 joshwiens

@d3viant0ne Happy New Year! Do you have an estimate on when this might be released?

randak avatar Jan 02 '18 20:01 randak

@d3viant0ne @michael-ciniawsky Any chance we could see a release for this this month?

randak avatar Jan 17 '18 00:01 randak

@mernen @d3viant0ne @michael-ciniawsky Could I get a status update on this?

randak avatar Mar 28 '18 07:03 randak

@bebraw @d3viant0ne @SpaceK33z @TheLarkInn Hi all, I'm not trying to be a pest, but is there anything I can do to help you get this released? Our team would really appreciate it. Thanks!

randak avatar Apr 25 '18 17:04 randak

@d3viant0ne did you abandon this change / project?

msphn avatar May 03 '18 09:05 msphn

😞

randak avatar May 21 '18 02:05 randak

I migrated to https://www.npmjs.com/package/svg-url-loader and it works fine for me. In case anyone else is interested. I removed all dependency to this lib.

msphn avatar May 21 '18 11:05 msphn

@msphn Thanks for the tip. Unfortunately, this loader has a lot of useful features that aren't included in that other loader (classPrefix is really important for me).

Fortunately, this still works with Webpack 4 (for me).

elliottregan avatar Jun 04 '18 20:06 elliottregan

Can I help you, to get this PR into production?

dazlious avatar Jun 08 '18 15:06 dazlious

Is there any chance this could get pulled at some point? Is there any issue in the code that prevents that? Update would be very welcome in our team.

ddx32 avatar Oct 23 '18 13:10 ddx32

It is sad that this PR just sits here. Any change it can be integrated in a new release?

SuneRadich avatar Mar 12 '19 08:03 SuneRadich

Is there someone over at the core Webpack team that can add someone else as a maintain to this repo? Or maybe transfer ownership if it isn't going to be maintained with the rest of Webpack?

@sokra @jhnns @TheLarkInn @spacek33z

elliottregan avatar Mar 14 '19 22:03 elliottregan

⬆️ @webpack @webpack-contrib

elliottregan avatar Mar 14 '19 22:03 elliottregan

@bebraw, @TheLarkInn, @spacek33z - Anyone know what happened to @d3viant0ne ? His last contribution was in February?

will-russell avatar Apr 04 '19 16:04 will-russell

@will-russell He (amongst some other developers me included) isn't active in the project anymore.

bebraw avatar Apr 04 '19 17:04 bebraw

@will-russell He (amongst some other developers me included) isn't active in the project anymore.

@bebraw - thank you for the reply!

Who was left in charge of the project; do they know this is hanging out there?

RE: @TheLarkInn @spacek33z

will-russell avatar Apr 04 '19 17:04 will-russell

@will-russell I think it's up to the current contrib team to maintain. Someone show pick up the PR and merge.

CC @evilebottnawi.

bebraw avatar Apr 04 '19 17:04 bebraw

In todo

alexander-akait avatar Apr 04 '19 17:04 alexander-akait

Are there any news on this issue?

aramin avatar Jun 24 '19 11:06 aramin

πŸ¦—πŸ¦—πŸ¦—

elliottregan avatar Oct 31 '19 01:10 elliottregan

Also waiting for this

liorgreenb avatar Jan 01 '20 16:01 liorgreenb

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d2c7218). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage          ?   45.51%           
=========================================
  Files             ?        5           
  Lines             ?      156           
  Branches          ?       45           
=========================================
  Hits              ?       71           
  Misses            ?       73           
  Partials          ?       12           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update d2c7218...27f9e37. Read the comment docs.

codecov[bot] avatar Apr 10 '20 12:04 codecov[bot]