mini-css-extract-plugin icon indicating copy to clipboard operation
mini-css-extract-plugin copied to clipboard

Published 20 hours ago • verified publisher icon webpack-contrib

feat: add stats option

Open niedzielski opened this issue 4 years ago • 7 comments

This PR contains a:

  • [ ] bugfix
  • [x] new feature
  • [ ] code refactor
  • [ ] test update
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

Expose a stats option to make hot module replacement and other informational messages optional. Only stat presets are supported but the API can be expanded to an object later if useful.

Breaking Changes

Additional Info

niedzielski avatar Jun 11 '20 01:06 niedzielski

So far as I can tell, these errors are false positives due to preexisting security audit failures.

niedzielski avatar Jun 11 '20 02:06 niedzielski

Thank you for the fast feedback, @evilebottnawi! I'm sorry but I didn't quite understand the feedback. Are you saying to use the Webpack logger API, to abandon this change, or something else? Thank you!

niedzielski avatar Jun 11 '20 13:06 niedzielski

Yes webpack logger API

alexander-akait avatar Jun 11 '20 13:06 alexander-akait

@evilebottnawi, done (I think).

Edit: I tried to mimic the webpack-dev-server implementation and options as the HMR client context is very similar.

niedzielski avatar Jun 12 '20 03:06 niedzielski

webpack-dev-server@4 migrate on built-in webpack logger

alexander-akait avatar Jun 12 '20 12:06 alexander-akait

@evilebottnawi, thank you. Is this a good example to base the approach on?

niedzielski avatar Jun 12 '20 18:06 niedzielski

https://github.com/webpack/webpack-dev-server/pull/2631

alexander-akait avatar Jun 13 '20 13:06 alexander-akait