image-minimizer-webpack-plugin icon indicating copy to clipboard operation
image-minimizer-webpack-plugin copied to clipboard

Published 20 hours ago • verified publisher icon webpack-contrib

chore: disable some broken tests

Open RAX7 opened this issue 2 years ago • 5 comments

This PR contains a:

  • [ ] bugfix
  • [ ] new feature
  • [ ] code refactor
  • [x] test update
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

Because squooshLib is broken on Windows and some Node versions:

  • disable some tests for Windows and Nodejs > 14
  • disable some tests for all and Nodejs > 16

RAX7 avatar Sep 10 '22 10:09 RAX7

Codecov Report

Base: 87.71% // Head: 87.71% // No change to project coverage :thumbsup:

Coverage data is based on head (082cda2) compared to base (a57fcdf). Patch has no changes to coverable lines.

:exclamation: Current head 082cda2 differs from pull request most recent head 9410e66. Consider uploading reports for the commit 9410e66 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files           4        4           
  Lines         643      643           
  Branches      243      243           
=======================================
  Hits          564      564           
  Misses         71       71           
  Partials        8        8

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 10 '22 10:09 codecov[bot]

Maybe because one of snapshots becomes obsolete if I disable the test case that uses it. I don't know how to fix it

Test Suites: 13 passed, 13 total
Tests:       31 skipped, 173 passed, 204 total
Snapshots:   1 obsolete, 60 passed, 60 total
Time:        51.569 s
Ran all test suites.
Error: Process completed with exit code 1.

RAX7 avatar Sep 13 '22 11:09 RAX7

We can rewrite the snapshot test on simple except, so we will not have condition tests (i.e. when we have snapshot on linux, but don't have it on windows)

alexander-akait avatar Sep 13 '22 15:09 alexander-akait

I just replaced squoosh with sharp for this test. And some tests on macos now fail. Test on windows was canceled. 😕

RAX7 avatar Sep 13 '22 16:09 RAX7

@RAX7 Let's try to finish, thank you

alexander-akait avatar Sep 22 '22 21:09 alexander-akait

Thank you for the PR, fixed in master, inspired by your code :star:

alexander-akait avatar Oct 26 '22 19:10 alexander-akait

@alexander-akait Oh, that's great! And sorry for the late reply.

RAX7 avatar Oct 27 '22 05:10 RAX7