html-loader icon indicating copy to clipboard operation
html-loader copied to clipboard

docs(readme): restore extract-loader usage

Open fruchtose opened this issue 3 years ago • 1 comments

This PR contains a:

  • [ ] bugfix
  • [ ] new feature
  • [ ] code refactor
  • [ ] test update
  • [x] typo fix
  • [ ] metadata update

Motivation / Use-Case

The docs mention the use of extract-loader, but the example which mentions it does not actually use it. This appears to be an unintentional change made as part of #423, as that pull request does not mention any intent to change the docs.

Additional Info

I tested the example configuration using webpack 5, html-loader v4.1.0, and extract-loader v5.1.0.

fruchtose avatar Sep 20 '22 07:09 fruchtose

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: fruchtose / name: Robert Fruchtman (66a729fc1dcb40f30ec1d672bb0b8115a40f210a)

Codecov Report

Base: 92.20% // Head: 92.20% // No change to project coverage :thumbsup:

Coverage data is based on head (66a729f) compared to base (37d2073). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #459   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files           7        7           
  Lines         590      590           
  Branches      190      190           
=======================================
  Hits          544      544           
  Misses         37       37           
  Partials        9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 06 '22 14:10 codecov[bot]

Sorry for delay, close because of https://github.com/webpack-contrib/html-loader/issues/404

alexander-akait avatar Jan 16 '24 15:01 alexander-akait