css-minimizer-webpack-plugin icon indicating copy to clipboard operation
css-minimizer-webpack-plugin copied to clipboard

remove mini-css-extract-plugin from example webpack configuration

Open sportshead opened this issue 4 years ago • 5 comments

fixes #65

This PR contains a:

  • [ ] bugfix
  • [ ] new feature
  • [ ] code refactor
  • [ ] test update
  • [x] typo fix
  • [ ] metadata update

Motivation / Use-Case

Makes things less confusing #65

Breaking Changes

None.

Additional Info

sportshead avatar Mar 15 '21 05:03 sportshead

mini-css-extract-plugin is not required to working with this plugin

So are you saying it is required or not?

sportshead avatar Mar 31 '21 12:03 sportshead

It is required when you want to extract CSS, but you can copy CSS files using copy-webpack-plugin (just one example)

alexander-akait avatar Mar 31 '21 12:03 alexander-akait

So it is not required for this plugin to function

sportshead avatar Mar 31 '21 12:03 sportshead

Codecov Report

Merging #70 (6618980) into master (8865423) will increase coverage by 9.28%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   90.21%   99.50%   +9.28%     
==========================================
  Files           5        3       -2     
  Lines         276      200      -76     
  Branches      100       67      -33     
==========================================
- Hits          249      199      -50     
+ Misses         25        1      -24     
+ Partials        2        0       -2     
Impacted Files Coverage Δ
src/cjs.js 100.00% <0.00%> (ø)
src/Webpack5Cache.js
src/Webpack4Cache.js
src/index.js 100.00% <0.00%> (+3.24%) :arrow_up:
src/minify.js 93.33% <0.00%> (+38.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8865423...6618980. Read the comment docs.

codecov[bot] avatar Mar 31 '21 13:03 codecov[bot]

Yes, but popular usage with mini-css-extract-plugin, let's add comment about it, no need to remove

alexander-akait avatar Mar 31 '21 13:03 alexander-akait