awesome-webpack icon indicating copy to clipboard operation
awesome-webpack copied to clipboard

feat(plugins): add butternut plugin

Open balthazar opened this issue 8 years ago • 16 comments
trafficstars

balthazar avatar May 18 '17 04:05 balthazar

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Balthazar Gronon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

jsf-clabot avatar May 18 '17 04:05 jsf-clabot

@Apercu duplicate https://github.com/webpack-contrib/awesome-webpack/pull/67

alexander-akait avatar May 18 '17 09:05 alexander-akait

@evilebottnawi not a duplicate, the other one is a different one that was made after for strange reasons

balthazar avatar May 18 '17 14:05 balthazar

@Apercu @MaxGraey guys, it is badly that we have two plugins with same goal, maybe your can unite and put your efforts together.

alexander-akait avatar May 18 '17 14:05 alexander-akait

https://github.com/Rich-Harris/butternut/pull/124

balthazar avatar May 18 '17 14:05 balthazar

@evilebottnawi You are free to choose which plugin would be in this repo. And I closed Rich-Harris/butternut#124. So we won't collide

MaxGraey avatar May 18 '17 14:05 MaxGraey

@Apercu i reopen this issue, but you seriously should come to one solution, several solutions uglify emerged in about the same circumstances, and this is badly to ecosystem. Beginners can confused.

alexander-akait avatar May 18 '17 14:05 alexander-akait

In my opinion the competition on the contrary improves the ecosystem, the choice is always welcome. For example there is the npm and we also have yarn. Both have their own advantages and disadvantages

MaxGraey avatar May 18 '17 14:05 MaxGraey

@MaxGraey Not in all cases, competition should be manifested when one product does not want to meet the goals that community wait, in your case your do the same thing, it's not a competition but a repetition. It is just my opinion.

alexander-akait avatar May 18 '17 15:05 alexander-akait

@MaxGraey I do not think you want to see webpack as many individual poorly coordinated repositories, it would be hell for developers. Besides speaking, the issue in which you did not agree is not of a serious nature. You can always ask someone from webpack (slack, gitter, github) community and take it for granted.

alexander-akait avatar May 18 '17 15:05 alexander-akait

@evilebottnawi So, we have different opinions and that great. But what if one solution better in some aspects or has completely different implementation? Anyway what is the solution to leave it up to you as maintainer.

MaxGraey avatar May 18 '17 15:05 MaxGraey

I will accept any your decision if it will be useful to the community

MaxGraey avatar May 18 '17 15:05 MaxGraey

@MaxGraey I'll leave it here until someone else has seen it.

In fact, the main problem is that when you two or more you can make the product better. Also, if one of you is absent for some reason, the other will be able to solve problems and publish new versions. Many repositories are abandoned for this reason. But I have no right to tell you how it do right, just my advice, no more.

alexander-akait avatar May 18 '17 15:05 alexander-akait

There isn't a problem with having more than one loader / plugin covering the same functionality as far as the list goes though personally I try to avoid duplicating libs whenever possible when publishing them.

That said and this is applicable to both butternut plugins, part of the guidelines for the parent awesome-list from sindresorhus is libs need to have a certain amount of maturity before they are added. The generally accepted minimum based on age is 4-6 weeks and normally a few releases as proper maintenance is definitely a part of awesome.

So, all that said there doesn't need to be a choice between one plugin or the other as @MaxGraey said, a certain amount of competition drives innovation but in both cases here the libs need to mature a bit more before they are added.

Both pull request can remain open and we will revisit this topic in the future based on the above criteria.

joshwiens avatar May 19 '17 20:05 joshwiens

@ballercat please accept CLA

alexander-akait avatar Jun 09 '18 13:06 alexander-akait

Please rebase

alexander-akait avatar Feb 05 '19 08:02 alexander-akait