meta-webosose icon indicating copy to clipboard operation
meta-webosose copied to clipboard

Consider dropping need for META_WEBOS_LAYER etc to be set

Open rossburton opened this issue 1 year ago • 5 comments

As you control meta-webos, there's no need for the recipes to expect that META_WEBOS_LAYER has been set. This being a requirement makes it tricky to build webos outside of build-webos, as these variables also need to be set by hand.

META_WEBOS_LAYER can be removed seamlessly by simply setting it in meta-webos/conf/layer.conf:

META_WEBOS_LAYER := "${LAYERDIR}"

There's currently a single user of META_OE_LAYER. Arguably this could be added to meta-oe too, or the recipe restructured to avoid that need (for example, a clangifier BBCLASSEXTEND could work).

rossburton avatar Dec 18 '23 14:12 rossburton

@hieunv0828 Can you please reply here with the explanation why BBCLASSEXTEND didn't work together with multilib?

I've shared PR for this and #27, so that Ross can test the same fixes which are going to be merged internally on AB, without the need to recreate the commits from the diff you've shared in comment (which is also old version not using TOKEN) or creating his own commit for lemon backport. Do you know when there will be next OSE release on github?

shr-project avatar Jan 05 '24 12:01 shr-project

The next OSE release is planned at the week of Jan 15th.

jaeyoonjung avatar Jan 05 '24 13:01 jaeyoonjung

Hi @rossburton: As Martin's mentioned, the BBCLASSEXTEND didn't work together with multilib. I tried creating new simple class (extend.bbclass) and set BBCLASSEXTEND = "extend", but the Bitbake can't extend an extended recipe (https://bugzilla.yoctoproject.org/show_bug.cgi?id=13424), so I can't bitbake lib32-googletest-extend. We set META_OE_LAYER variable in meta-webos/conf/layer.conf:

META_OE_LAYER ??= "${@'${BBFILE_PATTERN_openembedded-layer}'[1:-1]}"

Then I can build webos outside of build-webos. So you can remove hardcode two paths in JSON configs after #30 is merged.

hieunv0828 avatar Jan 06 '24 08:01 hieunv0828

@rossburton We have already set META_WEBOS_LAYER and META_OE_LAYER in meta-webos/conf/layer.conf on master branch (https://github.com/webosose/meta-webosose/commit/f81893d02a6232ca4b7bfe9d7e0c124e0617a4b4) You can remove the hard code these variables in autobuilder configurations.

hieunv0828 avatar Jan 19 '24 06:01 hieunv0828

@rossburton < https://github.com/webosose/meta-webosose/commit/f81893d02a6232ca4b7bfe9d7e0c124e0617a4b4 This fixes this issue. Please check it out and move forward to next step. Thanks!

jaeyoonjung avatar Jan 23 '24 23:01 jaeyoonjung