youtube-webos icon indicating copy to clipboard operation
youtube-webos copied to clipboard

SponsorBlock segments not rendered on videos with chapters

Open Informatic opened this issue 3 years ago • 3 comments

Seems like chapters have just been rolled out to YouTube TV. This causes our SponsorBlock segments rendering to break.

Skips are properly executed.

Test video: https://www.youtube.com/watch?v=R3iNAQqqnjE Screen capture

Informatic avatar Dec 24 '21 21:12 Informatic

New slider class: .ytlr-multi-markers-player-bar-renderer slider

Informatic avatar Dec 24 '21 21:12 Informatic

Another issue: original slider is replaced with segmented one fairly randomly - we now also need to watch for slider removal in parent node. Whoops.

Informatic avatar Dec 24 '21 22:12 Informatic

Just an update on this: I've made a quick preact component a while back that emulates the rect and opacity/visibility of a unmanaged element in a managed element which would allow having the sponsorblock overlay "in" the slider while being out of YT's VDOM. The only reason I haven't made a pull request with it is because I had trouble emulating the proper stacking context which means the sponsorblock overlay would not be behind certain elements as it should be, causing minor visual bugs.

Just ping me if you want the code for it as I'm busy with other stuff.

LuminescentMoon avatar Mar 30 '22 02:03 LuminescentMoon