webosbrew
Bug: SponsorBlock segments are not shown on the seek bar any more
YTAF information
- YTAF version: 0.3.7
TV information
- webOS version: 4.10.1-24
- Firmware version: 05.40.80
- OTAID: HE_DTV_W19O_AFABABAA
- SoC: o18
- Model: OLED65C9PLA
Issue description
I don't see SponsorBlock segments on the seek bar any more. The segments are still skipped, they are just not shown on the seek bar. This started a few days ago. Maybe when I updated to YTAF version 0.3.7. Or maybe it is caused by the CSS class renames that YouTube did.
Thank you for posting this bug because if you hadn't done so, I was going to. Just to add to your report, the skipped/blocked section on the seek bar has been gone for a long time now. It didn't start with just 0.3.7. Back a few versions ago, the seek bar was an excellent way to see graphically just how good and effective YTAF really is, because all the rubbish no-one needs to see was coloured green or another colour to contrast against the actual content section which was the usual red. Now though the seek bar is only one colour, red for the entire length no matter how many skipped/blocked sections there are. It matters because if there is a skipped section you do actually want to watch, you used to be able to identify exactly where it started and ended by the change in colour so you could accurately FF/REW back to where you knew it would start. Now with the seek bar always red, this is pure guesswork to do.
A return back to the graphical way the seek bar used to work would be greatly appreciated. If this could be fixed at the same time as blocking all the top line inserted shorts videos of subcribed channels, then YTAF would be vastly improved.
I think it could be because Youtube updated the seek bar. It used to be solid red, but now it's a gradient from red to purple.
I think it could be because Youtube updated the seek bar. It used to be solid red, but now it's a gradient from red to purple.
I think you're right. I hadn't really noticed that in standard YT since I never use it, but I have been wondering if it's just my eyes or whether the seek bar in YTAF does have different shades of varying bits of transitioning pink through purple in it around the mostly red sections. Not that these are any help at all in identifying where the ads/rubbish/noise is in the stream.
While I am not well versed in JS I fixed the issue and it's available on my fork. Tested on webOS 24 simulator and LG G4. Let me know if all is good 👍
https://github.com/NicholasBly/youtube-webos/releases/tag/0.3.9
It works! and you sir, are nothing short of a genius. I never even bothered to complain about the weird traffic cone clown hat icon for YTAF, so thank you for changing that too.
Whoops! Sorry, I was too quick to say it works. Yes the seek bar displays in different colours, but there's a major downside in that the app now crashes catastrophically on every execution of (I think) Skip Self-Promotion and maybe also Skip Outro. I've had it just stall and hang endlessly. I've had a continuous row of stacked "Skipped Self-Promotion" notices all up the right side of the screen. I've had the screen just go to black at the end of a video and never recover. There are major problems with 0.3.9 that it should not be used. I've had to go back to 0.3.8 again because I can't be forced to re-login to youtube again everytime I switch video.
Oh wow. Didn't come across that, I tested a few videos that had every segment type. You can try 0.4.0 I pushed yesterday, but if you can link me the YouTube video that issue occurred on I can attempt to fix that. Thanks
Basically every video from: scaredketchup Brian Tyler Cohen Jack Cocchiarella Rebel HQ MSNBC Jesse Dollemore David Packman Stephen Colbert Jimmy Kimmel Farron Balanced Occupy Democrats
Also, if the app logo can be easily changed, then can you choose a more square shaped version that better fills the square tile shape display area, rather than the long horizontal one with the full name? There are many options here: https://www.cleanpng.com)/free/youtube.html I'd suggest the less-is-more approach would be best for a tile logo. Something very simple and 2D without any text at all would be best given the limited size. This one would fit the bill: https://www.cleanpng.com/png-youtube-play-button-computer-icons-clip-art-icon-l-610027/
Without knowing anything about coding, I'd guess the app doesn't know what to do after skipping a segment that is at the end of a video. ie. when it skips a section but then doesn't have any more video to go to after the skip. Rather than just exit and end gracefully, it seems to get trapped in a logic loop about what to do next and crashes.
Sure, I can update the logo. One of the videos I tested was the Veritasium video with Tom Brady, it has a endcard/credit segment that ends the video, I tested that and it worked perfectly for me. But what you described makes sense. What TV model /software are you testing on? I won't be able to look at or update the project for a couple days as I'm out of town.
I also used your 0.4.0 and noticed the skip intro (I think, can't remember 100% now) was stacked up 5 or 6 times, but the app didn't crash. Weird nonetheless.
I'm testing that football tossing video now. The start stalled for an unusually long time presumably skipping all the intro crap. Didn't crash, but took a long time to process the skippage.
Testing screen is an LG 43” TV - LG43UP8000PTB running WebOS v6.5.1-37 (kisscurl-koli) YTAF now updated to v0.4.0
Now that you've compressed the options screen (green button), you've freed up a lot of real estate to add one new option called "auto login" whereby the default user pre-selected upon startup of YouTube can be auto-clicked by YTAF instead of the user having to press the OK button on the remote every single time. Let's be honest, 99.9% of users will never be looking to change the user on startup, so this stupid screen YouTube forces everyone to interact with is a right PITA
The start stalling might not be related to the extension, there is a big stall going around with people with adblockers. I have it on my PC with uBlock origin. People are saying YouTube is flagging Adblock users and forcing a 5-15 second delay at starts of videos. I have tested not signed in and with a premium account so I haven’t experienced this issue on webOS.
Yeah the auto login is a good idea. Could write some logic to determine the current page and auto send the ok button.
The start stalling might not be related to the extension, there is a big stall going around with people with adblockers.
No adblocker here on TV webOS (other than what may or may not be embedded inside YTAF)
Yeah the auto login is a good idea. Could write some logic to determine the current page and auto send the ok button.
The football tossing video finished without any crashing using v0.4.0. Now watching Le Mans free practice on FIA WEC and this seems to be working perfectly fine too so far.
The first option in the options panel blocks ads, so it's possible it's due to YouTube flagging your account for blocking ads. I've read that you can turn off Adblock and watch a few ads and the start stall will go away for a while.
Maybe one more suggestion. The sponsorblock segments are color coded, would be nice to see the colors (which color blocks what) when you click green button or something. I like your feature to jump to the highlight, but I wouldn't know if the video has a highlight and which color it is.
Sure, I can update the logo.
For the sake of maintaining the distinction between YTAF and the genuine original YouTube app, it's probably a good idea to not make the YTAF icon exactly the same as the YouTube one. Given that webOS can't have both apps installed side by side simultaneously, it makes sense to have different icons, so at a glance one can tell which version is currently installed.
Maybe one more suggestion. The sponsorblock segments are color coded, would be nice to see the colors (which color blocks what) when you click green button or something. I like your feature to jump to the highlight, but I wouldn't know if the video has a highlight and which color it is.
I'm sorry to have to report that v0.4.0 still crashes the app. It always crashes at the end of a video. The video either just hangs on the last decodable frame, or the screen simply goes to black and stops responding. Pressing the BACK button can sometimes force YTAF to display an endlessly long stack of messages all up the right side of screen saying what it's trying to do. If I knew what the colours on the seek bar coded to doing, then I might be able to provide better troubleshooting feedback. As it is, I've seen an endless stack of 'Skipping Outro' and an endless stack of 'Skipping Self-Promotion' messages in two instances of crashes.
The fact that there are endless stacks of messages, tells me the code enters some sort of endless logic loop from which it can't escape. I've seen this most frequently on multiple Stephen Colbert videos, but it is far from unique to that one channel. At the end of Stephen Colbert segment videos there is always a CBS logo which is always skipped. The app crashes as soon as the CBS logo starts to appear, if that helps at all?
Alright seems like the bug I found with manually entering segments is probably related or the same bug, as it did reproduce that notification spam. Hopefully I can fix it tonight or tomorrow and push an update - I appreciate the feedback/testing
Alright all I had to do was revert the changes made to scheduleSkip() and it's fixed now, you can grab it from my github actions page, if you want it immediately, but gonna work on making some icons and an OLED-care mode for the options and notification menus. I also have in my notes to do custom hex color codes for each segment type and auto login, not sure if i'll fit all of that in the next update but they're all planned
0.4.1 pushed
Hi, skipping works great now. But how do you choose a different color for the segments? When I press on it, nothing happens.
Also, maybe we should write about it in your fork..? Or do you plan to merge it here with a pull request sometime later?
btw. I like that you put in new features in this app, I really appreciate it!
Also, one more suggestion. If there is a Highlight, is it possible to show a small text somewhere to let the user know there is a Highlight, without looking at the seekbar?
0.4.1 pushed
Tested on problematic Stephen Colbert videos that previously crashed and all is working fine now, thank you very much. Really looking forward to the Auto-User Login function addition. May I ask what the 'OLED-care mode' function is for? I can see it changes the menu colour from red to black, is there more to it than that? Do OLED screens struggle with displaying red for some reason?
0.4.1 pushed
May I ask what the 'OLED-care mode' function is for? I can see it changes the menu colour from red to black, is there more to it than that? Do OLED screens struggle with displaying red for some reason?
Older OLED panels degrade faster when showing the color red, I made it for that reason. Will it make a difference, probably not.
But how do you choose a different color for the segments? When I press on it, nothing happens.
You can use the remote cursor to click on the color and it should bring up a color selection box.
But how do you choose a different color for the segments? When I press on it, nothing happens.
You can use the remote cursor to click on the color and it should bring up a color selection box.
I tried that, but nothing happens if I click
But how do you choose a different color for the segments? When I press on it, nothing happens.
You can use the remote cursor to click on the color and it should bring up a color selection box.
I tried that, but nothing happens if I click
Hmm I tested on webOS simulator using a mouse, thought the cursor from the remote should act the same, but haven't tested on an LG TV yet. You can try using the up and down arrows to select the tab and then click the color box with either remote or the scroll wheel click
Hmm I tested on webOS simulator using a mouse, thought the cursor from the remote should act the same, but haven't tested on an LG TV yet. You can try using the up and down arrows to select the tab and then click the color box with either remote or the scroll wheel click
Just on the off chance it helps at all, I have TVs running both webOS 6 and 24 and can confirm the colour selection option doesn't show as working on either of them. Not a big deal for me to be honest as this functionality is not a priority AFAIC, but I just put this out there as info to know.
Anybody got any idea why this v0.4.1 isn't the new standard release? I mean it's so much better in every way than 0.3.8 or 0.4.0, so why isn't it being shown as the new standard release for everybody?
v0.4.2 needs to incorporate the auto-click login feature previously requested… hopefully before I wear out my remote constantly pressing the wheel button!