youtube-webos icon indicating copy to clipboard operation
youtube-webos copied to clipboard

Bug: Broken on webOS 1 and 2

Open throwaway96 opened this issue 10 months ago • 17 comments

Apparently 0.3.4-rc1 doesn't work on webOS 1 and 2. I wasn't even aware that it worked on those versions, since they use WebKit for WAM.

I'm not actually sure which webOS versions each YTAF release is broken on. As I have said elsewhere, it's difficult/impossible for me to properly test on webOS <4, so I have to rely on reports from users. ~~I think 0.3.3 may work on webOS 1/2, but I'd like someone to confirm that.~~ 0.3.3 does not work on webOS 1/2 either.

The problem is that the userscript is not running at all (due to a syntax error in the case of 0.3.3 on webOS 3.x). Users often can't tell the difference between YTAF running but failing to block some ads and the YTAF userscript not running at all. Generally, if the green button doesn't bring up the options panel, the userscript isn't running. I'm thinking about adding something to make it more obvious. Maybe another userscript with very simple JS that will display an error if the main YTAF userscript doesn't run.

throwaway96 avatar Apr 10 '24 22:04 throwaway96

Have you tried adding the appropriate browsers to .browserslistrc?

fire332 avatar Apr 11 '24 00:04 fire332

It doesn't seem like browserslist supports WebKit—at least not directly. Maybe ios_saf or something?

throwaway96 avatar Apr 11 '24 00:04 throwaway96

Honestly, those browsers are so old that it's worth having a separate build for them to not unload a truck load of redundant polyfills for newer webOS versions.

fire332 avatar Apr 11 '24 01:04 fire332

0.3.3 does not work on WebOS 1.0, no green button etc. 0.3.2 is the last working version.

mrmuiz avatar Apr 11 '24 17:04 mrmuiz

This should run on webOS 1 and 2 and block most of the new ads: https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.2-webkit1

throwaway96 avatar Apr 12 '24 00:04 throwaway96

This should run on webOS 1 and 2 and block most of the new ads: https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.2-webkit1

Works like a charm !! Very cool. THX !! Tested on WebOS 1

mrmuiz avatar Apr 12 '24 20:04 mrmuiz

People with webOS 1 or 2: please try https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.5-dev2.

throwaway96 avatar May 27 '24 21:05 throwaway96

Does not work... installed 0.3.2 again... works fine on webos 1

mrmuiz avatar May 27 '24 22:05 mrmuiz

Hmm, I get pre-roll ads on version 0.3.2 (WebOS 1.4)

h3ndrik avatar May 28 '24 12:05 h3ndrik

Hmm, I get pre-roll ads on version 0.3.2 (WebOS 1.4)

afbeelding Works fine on this version.

mrmuiz avatar May 28 '24 13:05 mrmuiz

I have webos 2, this is not work Dev Build v0.3.5-dev2, but v0.3.2-webkit1 work very good. thanks.

f-lirtik avatar Jun 22 '24 07:06 f-lirtik

I have webos 2, this is not work Dev Build v0.3.5-dev2, but v0.3.2-webkit1 work very good. thanks.

How can install this apk to webOS 1 device, please? If I try to install it via HomeBrew Dev Manager, I get an error: Unable to exec: luna-send-pub: Failed to call getIDs

Egorkat avatar Jun 24 '24 13:06 Egorkat

@Egorkat

What version of Dev Manager are you using? If not the latest one, then try that.

throwaway96 avatar Jun 24 '24 13:06 throwaway96

It is latest 1.13.3

Egorkat avatar Jun 26 '24 11:06 Egorkat

Note: The correct workaround as of now is v0.3.2-webkit1 as throwaway96 said. That works for me on webOS 1.4. Has Sponsorblock working and removes the pre-roll ads.

Just don't make the same mistake I made and install the regular 0.3.2 version. That shows all the pre-roll ads, just Sponsorblock works. Later versions up to 0.3.4 don't work properly on webOS 1.

And a note to myself: Install downloaded IPKs via the Install button at the top of webos-dev-manager. If it fails, uninstall the app first. All the config will stay on the device. If you get some getID error, restarting the TV after the uninstall and reconnecting should make it work.

h3ndrik avatar Jul 14 '24 09:07 h3ndrik

Note: The correct workaround as of now is v0.3.2-webkit1 as throwaway96 said. That works for me on webOS 1.4. Has Sponsorblock working and removes the pre-roll ads.

Just don't make the same mistake I made and install the regular 0.3.2 version. That shows all the pre-roll ads, just Sponsorblock works. Later versions up to 0.3.4 don't work properly on webOS 1.

And a note to myself: Install downloaded IPKs via the Install button at the top of webos-dev-manager. If it fails, uninstall the app first. All the config will stay on the device. If you get some getID error, restarting the TV after the uninstall and reconnecting should make it work.

same too me

Device: 32LS650V Firmware :04.06.75 Webos Version: 2.2.0

kotucocuk avatar Jul 28 '24 21:07 kotucocuk

Just confirm that v0.3.2-webkit1 is working on my 42LB673V (WebOS 1.4.0-2536). Thanks!

truealex81 avatar Sep 22 '24 18:09 truealex81