apps-repo icon indicating copy to clipboard operation
apps-repo copied to clipboard

Aerial screensaver for webOS

Open aabytt opened this issue 1 year ago • 1 comments

aabytt avatar May 12 '24 22:05 aabytt

Check Results for webos.custom-screensaver-aerial.yml:

Package Metadata

:white_check_mark: Check passed.

Compatibility Check

App webos.custom-screensaver-aerial

Skip because this component is not native

All OK

github-actions[bot] avatar May 12 '24 23:05 github-actions[bot]

Hi @aabytt, thanks for the submission. There are a few things I'm concerned about:

  1. I think it's better to use your own package name prefix instead of org.webosbrew.
  2. Since the resources are linking to non-free resources, this app may better suit in non-free pool.

mariotaku avatar May 29 '24 00:05 mariotaku

  1. I think it's better to use your own package name prefix instead of org.webosbrew.

Sure, will do

  1. Since the resources are linking to non-free resources, this app may better suit in non-free pool.

Could not find whether linked resources are non-free. Many github screensaver projects use them. Do you think it is better to unlink the app and resources leaving a user possibility to download resources with own link?

aabytt avatar May 29 '24 10:05 aabytt

Oh I see! The assets are externally linked so the second concern isn't a problem anymore :)

mariotaku avatar May 29 '24 11:05 mariotaku

  1. I think it's better to use your own package name prefix instead of org.webosbrew.

Hey @mariotaku, prefix changed

aabytt avatar May 30 '24 11:05 aabytt

Thanks. Very cool app!

mariotaku avatar May 30 '24 12:05 mariotaku

P.S. Could you add some screenshot to the descriptions? It looks very cool and would be better if the users can see it in the descriptions.

mariotaku avatar May 30 '24 12:05 mariotaku

To add screenshots I need to PR an updated .yml file, right?

aabytt avatar May 30 '24 13:05 aabytt

@aabytt Yes, exactly. Also I could help you make the update.

mariotaku avatar May 30 '24 13:05 mariotaku