RetroArch icon indicating copy to clipboard operation
RetroArch copied to clipboard

Update appinfo.json: AppId with proper structure

Open Herrie82 opened this issue 1 year ago • 2 comments

Description

In order to reuse these apps in non-TV environment (webOS OSE, LuneOS) it would require to have a properly formatted appId for AppInstallD to be happy.

This should work on TV's too, however not tested at my end.

Related Issues

RetroArch doesn't install on LuneOS and webOS OSE.

Nov 08 13:03:03 qemux86-64 webapp-mgr.sh[548]: [548:548:1108/130303.039514:INFO:CONSOLE(300)] org.webosports.app.preware "PackageId: com.retroarch", source: file://org.webosports.app.preware-webos/usr/palm/applications/org.webosports.app.preware/build/app.js (300) Nov 08 13:03:03 qemux86-64 org.webosports.service.ipkg[504]: Running command /usr/bin/curl -s -I --user-agent Preware --location --fail --show-error file:///media/internal/com.retroarch_1.9.1_arm.ipk 2>&1 Nov 08 13:03:03 qemux86-64 org.webosports.service.ipkg[504]: Running command /usr/bin/curl --user-agent Preware --create-dirs --location --fail --show-error --output /media/internal/.developer/com.retroarch_1.9.1_arm.ipk file:///media/internal/com.retroarch_1.9.1_arm.ipk 2>&1 Nov 08 13:03:03 qemux86-64 org.webosports.service.ipkg[504]: Running command /usr/bin/ar p /media/internal/.developer/com.retroarch_1.9.1_arm.ipk control.tar.gz | /bin/tar -O -z -x --no-anchored -f - control | /bin/sed -n -e 's/^Package: //p' 2>&1 Nov 08 13:03:03 qemux86-64 org.webosports.service.ipkg[504]: Running command /usr/bin/luna-send -n 6 luna://com.webos.appInstallService/install '{"subscribe":true, "id": "com.retroarch", "ipkUrl": "/media/internal/.developer/com.retroarch_1.9.1_arm.ipk"}' 2>&1 Nov 08 13:03:03 qemux86-64 appinstalld[396]: [] [pmlog] AppInstallD APP_INSTALL_REQ {"app_id":"com.retroarch","caller":"com.webos.lunasend-1126"} Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 appinstalld[396]: [] [pmlog] AppInstallD PACKAGE_INFO {"app_id":"com.retroarch","package":"com.retroarch","version":"1.9.1"} Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 sam[552]: [I][ApplicationManager][onAPICalled][APIRequest] API(/getAppInfo) Sender(com.webos.appInstallService) Nov 08 13:03:03 qemux86-64 sam[552]: [W][LunaTask][setErrCodeAndText] errorCode(2) errorText(Invalid appId specified OR Unsupported Application Type: com.retroarch) Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 sam[552]: [I][ApplicationManager][onAPICalled][APIRequest] API(/getAppInfo) Sender(com.webos.appInstallService) Nov 08 13:03:03 qemux86-64 sam[552]: [W][LunaTask][setErrCodeAndText] errorCode(2) errorText(Invalid appId specified OR Unsupported Application Type: com.retroarch) Nov 08 13:03:03 qemux86-64 appinstalld[396]: [] [pmlog] LS_SOCK {"ERROR_CODE":32,"ERROR":"Broken pipe","APP_ID":"com.webos.lunasend-1126","UNIQUE_NAME":"masZuwDN"} Error when attempting to send to fd: 11 Nov 08 13:03:03 qemux86-64 sam[552]: [I][ApplicationManager][onAPICalled][APIRequest] API(/running) Sender(com.webos.appInstallService) Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 LunaAppManager[639]: QWarning: QFSFileEngine::open: No file name specified Nov 08 13:03:03 qemux86-64 LunaAppManager[639]: QWarning: QFSFileEngine::open: No file name specified Nov 08 13:03:03 qemux86-64 ApplicationInstallerUtility[1131]: ApplicationInstallerUtility configured to not use cryptofs Nov 08 13:03:03 qemux86-64 ApplicationInstallerUtility[1131]: Install type is not passed, set to default internal. Nov 08 13:03:03 qemux86-64 ApplicationInstallerUtility[1131]: Install called with args: target: /media/internal/.developer/com.retroarch_1.9.1_arm.ipk, verify: false, uncompressed app size (in KB): 0 Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 ApplicationInstallerUtility[1131]: Step 3: executing: opkg -o /media/cryptofs/apps --add-arch all:1 --add-arch any:6 --add-arch noarch:11 --add-arch x86_64:16 --add-arch core2-64:21 --add-arch qemux86_64:26 install /media/internal/.developer/com.retroarch_1.9.1_arm.ipk -f /etc/palm/appinstalld/opkg.conf Nov 08 13:03:03 qemux86-64 ApplicationInstallerUtility[1131]: Step 3: ipkg resultStatus = 1 , exit status = 255 Nov 08 13:03:03 qemux86-64 ApplicationInstallerUtility[1131]: Non zero exit code from opkg install Nov 08 13:03:03 qemux86-64 appinstalld[396]: [] [pmlog] AppInstallD TASK_ERROR {"app_id":"com.retroarch","error_code":-5,"error_text":"FAILED_IPKG_INSTALL"} Nov 08 13:03:03 qemux86-64 sam[552]: [I][AppInstallService][onStatus][SubscriptionResponse] com.webos.appInstallService Nov 08 13:03:03 qemux86-64 sam[552]: [W][AppDescriptionList][scanApp][com.retroarch] /media/developer/apps/usr/palm/applications/com.retroarch is not exist Nov 08 13:03:03 qemux86-64 sam[552]: [W][AppDescriptionList][scanApp][com.retroarch] /media/cryptofs/apps/usr/palm/applications/com.retroarch is not exist Nov 08 13:03:03 qemux86-64 sam[552]: [W][AppDescriptionList][scanApp][com.retroarch] /media/system/apps/usr/palm/applications/com.retroarch is not exist Nov 08 13:03:03 qemux86-64 sam[552]: [W][AppDescriptionList][scanApp][com.retroarch] /usr/palm/applications/com.retroarch is not exist Nov 08 13:03:03 qemux86-64 sam[552]: [W][AppDescriptionList][scanApp][com.retroarch] /mnt/otncabi/usr/palm/applications/com.retroarch is not exist Nov 08 13:03:03 qemux86-64 sam[552]: [W][AppDescriptionList][scanApp][com.retroarch] /mnt/otycabi/usr/palm/applications/com.retroarch is not exist Nov 08 13:03:03 qemux86-64 sam[552]: [W][AppDescriptionList][scanApp][com.retroarch] Failed to scan AppDescription Nov 08 13:03:03 qemux86-64 LunaAppManager[639]: QWarning: QFSFileEngine::open: No file name specified Nov 08 13:03:03 qemux86-64 appinstalld[396]: [] [pmlog] AppInstallD IPK_INSTALL_FAIL {"app_id":"com.retroarch","status":2304} Nov 08 13:03:03 qemux86-64 appinstalld[396]: [] [pmlog] AppInstallD STATUS_UNDEF {"app_id":"com.retroarch","status":24} Nov 08 13:03:03 qemux86-64 appinstalld[396]: [] [pmlog] AppInstallD APP_REMOVE_REQ {"app_id":"com.retroarch","caller":"com.webos.appInstallService"} [/quote]

Herrie82 avatar Nov 09 '23 07:11 Herrie82

I agree that the name should be changed, however I don't think this is the right time to do it.

We are currently hoping that the webOS changes can be upstreamed and there can be an official webOS release. If that happens, something like com.retroarch.webos would be appropriate.

I'd like to avoid putting users through multiple name changes. Since configuration files are stored in the app directory, they will be lost when the app's name is changed (without a migration tool or manually copying them). And Homebrew Channel doesn't have any mechanism for smoothly handling package name changes.

If at some point it doesn't look like official releases will happen, then I would support changing the name to org.webosbrew.retroarch.

throwaway96 avatar Mar 01 '24 04:03 throwaway96

Sorry for the late reply. We've been discussing the new package name and given there are chances of getting upstreamed, org.webosbrew.retroarch may be problematic.

But we do agree the package name needs to be changed! I'll post updates soon.

mariotaku avatar Mar 01 '24 04:03 mariotaku