graphql-php icon indicating copy to clipboard operation
graphql-php copied to clipboard

Published 20 hours ago • verified publisher icon webonyx

amphp/amp v3 compatibility

Open abdullahseba opened this issue 2 years ago • 5 comments

The bundled AMP PHP adaptor is not compatible with APM V3 and causes an error when used. Amp server is listed as a dev dependency so maybe it should be version-locked until this is fixed?

abdullahseba avatar Oct 30 '23 23:10 abdullahseba

What is APM V3?

spawnia avatar Nov 28 '23 08:11 spawnia

Sorry, AMP v3*

abdullahseba avatar Nov 29 '23 05:11 abdullahseba

See https://github.com/webonyx/graphql-php/pull/1262#issuecomment-1427737342.

spawnia avatar Nov 29 '23 09:11 spawnia

If it's not being done now, the version should be locked to 2.x in composer.json?

abdullahseba avatar Dec 16 '23 23:12 abdullahseba

No, as it is an optional dependency.

spawnia avatar Dec 17 '23 10:12 spawnia