authentic-theme icon indicating copy to clipboard operation
authentic-theme copied to clipboard

File Manager: Future improvements

Open iliajie opened this issue 8 years ago • 110 comments

To make new File Manager shinier we need to add:

  1. Manage symbolic links - added on 19.20-beta5 (October 03, 2018) https://github.com/authentic-theme/authentic-theme/issues/629#issuecomment-426615864
  2. Extend search with ability to specify user and group, file type (file, directory, symlink) - added on 19.70-beta2 (December 24, 2020) https://github.com/authentic-theme/authentic-theme/commit/4ee8d653134c1c66e87d16bbf1490fcb472da292

To make it more powerful and comfortable to use, lets add some extra functionality:

  1. Ability to diff two files #612

  2. Movable and resizeable editor windows - added on 18.49 (May 18, 2017)

  3. Image viewer with simple editor functionality; audio and video player - added on 19.32 (April 28, 2019)

  4. Viewing archives content

  5. Ability to download directory - added on 19.14 (April 26, 2018) https://github.com/qooob/authentic-theme/commit/9f114ace9d262299e02cb877da22e8e9cb588562

  6. Selecting files/directories using wildcard

  7. Calculate and verify checksum of files - added

  8. Split and combine files

  9. Exclude from search given folders - _added on 19.38 (July 20, 2019)

  10. Multi-rename tool

  11. Add multiple uploads - added

  12. Add an option to automatically extract uploaded file(s) - added

  13. Edit/reorder bookmarks (not just delete/add)

  14. In File Manager, when extracting an archive, all files and folders gets root-root. In Java File Manager setting you can select the default user as "same as the directory". Or if you want to change you can do it in the upload dialog. And you also can select "Upload, Extract and Delete file" in one action. #52020 - added

  15. Tree-view - added on 19.10-beta1 (March 18, 2018) https://github.com/qooob/authentic-theme/issues/1066

  16. QuillJS - HTML, rich text editor - added on 19.10-beta4 (February 28, 2018) https://github.com/qooob/authentic-theme/issues/1031

  17. Integrate Disk Usage module

  18. Add text conversion for text editor - added

  19. Add ability to reset column sorting https://github.com/qooob/authentic-theme/issues/1088 - _added on 19.38 (July 20, 2019)

  20. Abort current call, when clicking the other link - added on 19.13-beta2 (April 17, 2018) https://github.com/qooob/authentic-theme/commit/3cdc3ec218384381c9107eed15db4781c21b229c

  21. Add management for password protected archives https://github.com/webmin/webmin/issues/702#issuecomment-378905759 - added on 19.32 (April 28, 2019)

  22. Manage file-size calculations on client-side for already calculated directories https://github.com/qooob/authentic-theme/issues/1136

  23. Add ACLs control https://github.com/authentic-theme/authentic-theme/issues/1229#issuecomment-437895185

  24. Upload directories -- added

Anything else you miss/wish? Please comment below.

iliajie avatar Jan 03 '17 15:01 iliajie

Feature Movable and resizeable editor windows has been added to 18.49 release.

Added dropdown menu with yummy stuff for the editor.

  1. Align Panels Vertically (when the menu is opened hold Alt to see the magic happening. Besides holding Shift will reverse panels arrangement)
  2. Toggle Soft Wrap
  3. Refresh Content
  4. Help (moved away from the top)

screenshot from 2017-05-16 17-03-14

iliajie avatar May 14 '17 19:05 iliajie

https://github.com/qooob/authentic-theme/commit/f086f2ad9b8bfb2e567c2706d5ed7bd313888425

iliajie avatar May 16 '17 14:05 iliajie

Added support for creating symbolic links in File Manager.

screenshot from 2018-10-03 15-08-32

iliajie avatar Oct 03 '18 12:10 iliajie

Google Chrome can't load file manager. demo:https://www.scall.xyz/file.mp4 File management is always loading.

The Firefox browser loads the file manager normally.

Sometimes it is normal, very confused.

xulinbao avatar May 10 '19 02:05 xulinbao

Hi,

May be it's sone fancy cache issue? Hit Ctrl+Alt(Options)+Shift+Meta(Control)+R.

Is Firefox and Chrome on the same machine? Is the accessed server the same?

iliajie avatar May 10 '19 05:05 iliajie

Did it solve your issue?

iliajie avatar May 11 '19 17:05 iliajie

If possible could you please fix better view on mobiles. Either menu more narrow or higher z-index for menu. Schowek02

That's not bad: Schowek03

sz00gun avatar May 14 '19 21:05 sz00gun

Not sure if this is the right place, but I would like an option to edit file manager settings on filemin. It would be useful to be able to enable/disable the encrypt feature and some other features for the virtual server owners.

jonathanisodme avatar May 20 '19 03:05 jonathanisodme

@leijonathan It's better to open separate issue.

I don't understand what you mean. What do you mean enable/disable encrypt feature?

iliajie avatar May 20 '19 06:05 iliajie

Hello @rostovtsev

Do you have any ETA about the point number 23 ?

Thank you very much.

qwrty-ftw avatar Aug 01 '19 07:08 qwrty-ftw

I am closing 19.3x branch soon with small bug fixes, and starting 19.4x. There I am adding new mail compose feature, and most likely, new read mail feature and other features, among which could be ACLs for File Manager.

Do you find this feature useful and worth time investments? I personally never had a need to deal with it. What are your real-life examples, when you would need it (just curious). I suppose it could go under existing Permissions modal, in case getfacl/setfacl commands are available and kernel supports it. Does device (fs) needs special acl flag upon mounting or it would just work?

iliajie avatar Aug 01 '19 08:08 iliajie

To be honest, I do not use ACL each day, but when I am using it, I prefer a graphical management, it's more clear, but i can deal with CLI. I use ACL to manage user acces to specific files/folder. For example many user/group can have RW acces to specific folder but not the other one.

But if it's not a hard work I would love see this improvement to your file manager :D

If i understand your last sentence, I think it's specific to each fs. For example, like ZFS, I should specified the correct flag to use ACL. (zfs set acltype=posixacl )

qwrty-ftw avatar Aug 01 '19 10:08 qwrty-ftw

@ochbob Okay, I'll look into it for 19.40 release. :smiley_cat:

iliajie avatar Aug 01 '19 10:08 iliajie

+1 for ACL

two other things would be

  • small view/dropdown to monitor ongoing/historic operations like file-transfers etc.
  • split/dual-view

snickers2k avatar Aug 06 '19 12:08 snickers2k

Hi,

May be it's sone fancy cache issue? Hit Ctrl+Alt(Options)+Shift+Meta(Control)+R.

Is Firefox and Chrome on the same machine? Is the accessed server the same?

Sorry, I just noticed the news, it is estimated that it is my local country network problem.

xulinbao avatar Aug 07 '19 08:08 xulinbao

@ilinbxu Which country in particular is that?

iliajie avatar Aug 07 '19 08:08 iliajie

In China, after I opened the VPN, it was normal.

xulinbao avatar Aug 07 '19 08:08 xulinbao

@ilinbxu Sorry to hear that, and I'm glad you're free from censorship now.

iliajie avatar Aug 07 '19 09:08 iliajie

@rostovtsev it would be great if keyboard navigation support could be added to the file manager tree -- this would be very helpful for accessibility users (keyboard only users and screen reader users) who do not use a mouse. Currently, the tree can receive focus, but you are unable to expand and collapse the tree using keystrokes, and also cannot navigate the tree. Expected behavior is:

  1. Up/down arrow: vertically navigate the tree
  2. Left arrow: collapse the node your highlight is in
  3. Expand the node your highlight is on

Note by the way that the screen reader can properly announce the name and collapse/expand status of the node receiving focus.

Please let me know if you'd rather I open a seperate issue and link it to this one -- would be glad to do that.

zuhairmahd avatar Aug 29 '19 17:08 zuhairmahd

Thank you for your suggestion. I will try to make it possible on the next release.

iliajie avatar Aug 29 '19 17:08 iliajie

Zuhair,

I have added this for you promptly. Try installing latest development version of the theme (19.40-alpha2) to give it a try. :smiley_cat:

iliajie avatar Aug 29 '19 17:08 iliajie

@rostovtsev that was quick! It is working as expected. I expected there to be a lag when moving in the tree while the other pain refreshes but it is actually pretty quick!

Thanks!

zuhairmahd avatar Aug 29 '19 17:08 zuhairmahd

@rostovtsev

  1. Is there a reason why double clicking on a file (e.g. public_html/index.html) does not open it or enable a preview / view of it ?

Same for right click on file - why do we not have "view" or "preview" option? Only edit ....

  1. Should folders on left main tree be yellow (mine are white but yellow on the right side pane)

  2. Could it be possible to add drag / drop from right pane to the left main tree?

solaceten avatar Sep 13 '19 03:09 solaceten

Is there a reason why double clicking on a file (e.g. public_html/index.html) does not open it or enable a preview / view of it ?

It sounds like possible improvement. I could do it, I think.

Same for right click on file - why do we not have "view" or "preview" option? Only edit

Nobody ever asked for it, so I have never done it. I think it's worth adding it, you're right.

Could it be possible to add drag / drop from right pane to the left main tree?

Umm, I guess it's possible. It will require some work though. Although, isn't it easier, and safer using hotkeys, as Ctrl-C/Ctrl-V (Cmd-C/Cmd-V on Mac) to copy/paste?


Edited:

Should folders on left main tree be yellow (mine are white but yellow on the right side pane)

I don't really know. May be. It would make it more consistent, I guess. I will think what I can do to improve icons for mime types and folders. It would require at least one more new yellow icon for opened folder.

iliajie avatar Sep 13 '19 11:09 iliajie

I think the reason why I didn't make yellow icon on the tree, is that it would make the tree look clogged.

iliajie avatar Sep 13 '19 11:09 iliajie

If possible could you please fix better view on mobiles. Either menu more narrow or higher z-index for menu.

Yes, it's better to use flexbox for it. Latest commit adds it. Have a look.

image

The more should be done in terms of File Manager controls itself.

iliajie avatar Nov 15 '19 13:11 iliajie

Okay, it's better to use flexbox for the whole header. I dropped old table layout and switched to native Bootstrap rows and columns.

Example:

flex_box_header

iliajie avatar Nov 15 '19 18:11 iliajie

One thing I'd like is when you hit ctrl+F to search, to be able to search the next code/word using the arrow, or by hitting a search button several times. I have seen the scroll bar with the search result, it's nicely done

campones avatar Nov 24 '19 19:11 campones

One thing I'd like is when you hit ctrl+F to search, to be able to search the next code/word using the arrow, or by hitting a search button several times.

You can already do it by hitting F3 to search forward and Shift+F3 to search back up. It's quite standard, even regular browsers support it nowadays.

I have seen the scroll bar with the search result, it's nicely done

Thanks. :smiley:

iliajie avatar Nov 24 '19 21:11 iliajie

Works great indeed, thanks!

campones avatar Nov 24 '19 23:11 campones