Hidden accordians - Permanetly unhide selctor in theme config

[shoulders]

SYSTEM INFORMATION
OS type and version	Ubuntu Linux 22.04.4
Webmin version	2.111
Usermin version	2.010
Virtualmin version	7.20.1
Theme version	21.10
Package updates	All installed packages are up to date

I don't think I every did a GitHub issue for this, I have had a look in this repo, Webmin and Virtualmin and could not find one. I also was not sure if @iliaross add this feature.

the background

The issue

Unless you hide any of the panels on your dashboard the hidden accordians selector will not be shown

I spent hours looking for this before I was willing to hide a panel I might need again

proposed solution

make the Hidden accordians selector in theme config visible all the time as there is no need for it to be hidden.

Additional

discussed here

https://forum.virtualmin.com/t/where-do-you-unhide-dashboard-panels/126925/5

[iliaross]

Hello,

For the latest release, I already made it clear in the alert where it can be un-hidden after it was hidden.

[shoulders]

This is great but not what I meant, althought this is helpful. I meant always show Hidden accordions in theme config

Code

https://github.com/webmin/authentic-theme/blob/0ca0f9e215fdad49e028158f1f0d5096295a8595/tconfig-lib.pl#L201-L204

I am guessing this is the right code.

Remove the following which will prevent "hidden accordions` select thing from being hidden in theme config.

# Exclude hidden panels if none
if (!$theme_config{'settings_sysinfo_hidden_panels_user'}) {
    push(@theme_settings_filter, 'settings_sysinfo_hidden_panels_user');
}

[iliaross]

This is great but not what I meant, althought this is helpful. I meant always show Hidden accordions in theme config

Sure, makes sense, thanks! I'll take a look.

[shoulders]

bump 😄

this is a nice easy one to fix

[iliaross]

Unless you hide any of the panels on your dashboard the hidden accordians selector will not be shown

I spent hours looking for this before I was willing to hide a panel I might need again

Why would you search for something that doesn’t exist?

I’m not sure displaying an empty select will be less confusing, but I did improve the message after the accordion was hidden, explaining where it can be found.

[shoulders]

This is an easy one

• before I hid the panels I wanted to make sure I knew where to unhide them.
• I could not find where to unhide the panels, ironically because this feature was hidden.
• As an end user this does not make sense that it is hidden and a few others on the forum had this issue, jimr thought the only way to restore the panels was to reset the the theme. I am sure there are other people and he has been using Webmin for years.
• I have never used a software where a setting like this would be hidden like this.

[iliaross]

• before I hid the panels I wanted to make sure I knew where to unhide them.

You can't really know what will happen until you actually hide the panel. :-)

I could not find where to unhide the panels, ironically because this feature was hidden.

You couldn’t find where it was hidden because we didn’t specify where to look. Now we do., e.g.:

As an end user this does not make sense that it is hidden and a few others on the forum had this issue, jimr thought the only way to restore the panels was to reset the the theme. I am sure there are other people and he has been using Webmin for years.

Ah, okay! Then in this case, we should always display a select with all available panels (whether selected or deselected), rather than showing an empty one. It's probably not an easy fix, but I’ll take a look!

I have never used a software where a setting like this would be hidden like this.

You actually have!! :--))

[shoulders]

One additional thought.

When this is implemented, the visible panels should be highlighted in the list.

[iliaross]

When this is implemented, the visible panels should be highlighted in the list.

Yes, just it is now for disabled ones.