🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко)

Results 3657 comments of 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко)

@JayBazuzi looks like you'll have to re-flow the paragraph now.

@gatoniel tokens are mandatory in v4 and v5 of the action (by the way, v5 was released several days ago so maybe you could bump to that). Though, secrets are...

Oh, I got confused and thought you were bumping codecov for a minute. I that case, it's out of the scope, you're right.

There's one by Simon Willison: https://github.com/simonw/python-lib

Ah, right. Could you add a test for the change?

> _new_conn() Looking into `urllib3`'s source, I'd say we should stop redefining its private method and set the `ConnectionCls` class attribute instead. This is out of the scope here but...

I suppose it may be okay to try-except that and re-raise as a `SystemExit` with an error message. Or even print an error to stderr and `sys.exit(70)`.