webiny-js icon indicating copy to clipboard operation
webiny-js copied to clipboard

carousel pb-element can not be deleted

Open woeps opened this issue 2 years ago • 0 comments
trafficstars

Version

5.37.2

Operating System

Linux

Browser

Firefox 116.0.2 (64-bit)

What are the steps to reproduce this bug?

  • open page builder editor (for any site)
  • add carousel element to page
  • try to delete the carousel / find the delete button

What is the expected behavior?

I expect the sidebar having the delete button present.

What do you see instead?

I cannot find a way to delete the carousel element.

Additional information

Carousel's source code has hardcoded canDelete(){return false}, which I believe leads to the delete button being hidden besides the setting "pb-editor-page-element-settings-delete" being used in the plugin.

Possible solution

Change the canDelete function to return true. I'm not sure if there are further dependencies or calculations needed to keep in mind.

woeps avatar Aug 31 '23 16:08 woeps