webiny-js icon indicating copy to clipboard operation
webiny-js copied to clipboard

Pagebuilder hiding paragraphs after page load

Open websuits opened this issue 3 years ago • 3 comments

Version

5.25

Operating System

OSX

Browser

Chrome

What steps will reproduce the bug?

Create a page add multiple paragraphs. At one point changes are not made on first publish, after you edit-publish again will appear. But the it's stops rendering the paragraphs, you can slightly see them on page loading, but after page load some paragraphs will dissapear.

What is the expected behavior?

Show all the paragraphs.

What do you see instead?

Nothing, empty

Additional information

A WYSIWYG editor will make it a lot more useful, also adding a class name field for all the element, including paragraphs.

Possible solution

After discussing with Ben we think react hydration might be the cause.

websuits avatar May 17 '22 21:05 websuits

+1 - we have a 2xcol grid on a page, with each column containing another grid, with one cell. That cell contains a headline and a paragraph. The paragraph is in the rendered HTML, and you can see it when the page loads, but when the css is applied, it disappears. I think this is because the element is being incorrectly parsed into HTML when it's pre-rendered. The pre-rendered HTML looks likes this (the content is not inside the <p> tag):

<p></p>
<div><br /></div>
Today, Strabo connects accounts from the following countries: UK, CAN,
USA, IRE, NED, SP, FR, NZ, and AUS. We expect to move next to India and
the Middle East
<p></p>

Definitely present in 5.26 as well.

jimjoes avatar May 19 '22 06:05 jimjoes

I have the same problem with version 5.16. It's so weird. Any workaround?

rsshilli avatar Jun 22 '22 21:06 rsshilli

Not sure about 5.16, but with 5.26 you can use bullets for the copy and remove the bullet itself - for visible,

like behaviour. As long as you don't use bullets elsewhere, you can also modify the

  • styles in the theme.
  • jimjoes avatar Jun 23 '22 04:06 jimjoes

    I’m experiencing the same issue on v5.33.2. Paragraphs are visible in page builder, but hidden on the published page.

    data-ux avatar Nov 23 '22 20:11 data-ux

    @data-ux we have this fixed in the unstable branch at the moment. We expect it to be released in the stable branch towards end of the quarter. This is the commit with the fix. https://github.com/webiny/webiny-js/commit/956625a786fca1e99ee0bf5d08c961c55038dd89 You can use §yarn patch§ to create a patch for that file within your project until we do the official release.

    SvenAlHamad avatar Nov 23 '22 20:11 SvenAlHamad

    Thanks @SvenAlHamad! I made the same change as the linked commit with yarn patch to package @webiny/app-page-builder and the issue is now resolved for me.

    data-ux avatar Nov 24 '22 13:11 data-ux

    I have the exact same problem, but trying yarn patch @webiny/app-page-builder I'm not able to find the file mentioned in the commit you mentioned @SvenAlHamad

    bchirico avatar Jan 28 '23 17:01 bchirico

    Just a note that this issue has been resolved with version 5.34.1.

    adrians5j avatar Jan 30 '23 14:01 adrians5j

    Happens here (after the block quote, before the form I was adding): https://dtqdfwu8z3mi4.cloudfront.net/hmm

    Version: Webiny v5.34.7

    @adrians5j

    ile avatar Apr 02 '23 01:04 ile