webi-installers icon indicating copy to clipboard operation
webi-installers copied to clipboard

Try testing in container

Open virzak opened this issue 1 year ago • 8 comments

virzak avatar Feb 19 '24 17:02 virzak

Hi @coolaj86,

Could you please approve the workflow?

virzak avatar Feb 27 '24 17:02 virzak

Hi @coolaj86. Hi @coolaj86,

Could you please approve the workflow?

virzak avatar Apr 01 '24 17:04 virzak

Hi @virzak,

Thanks for looking into this. I'm now available to focus on Webi during the next 2-3 weeks. If you're also available, I'll have a quick turn around time to work with you on this.

coolaj86 avatar May 16 '24 20:05 coolaj86

@coolaj86 let's do it!

virzak avatar May 16 '24 20:05 virzak

It looks like what you have here is simply creating a container, copying a curl binary into it, and then running webi on the fresh system to see if it installs pwsh.

Where do you want to take it?

I think my ideal would be something like:

  • not run on every push, but must be run before any ref: or feat: PR can be accepted
    (GitHub Actions is distractingly slow to have run on each commit)
  • track which things are expected to not work on Alpine, or macOS, or Windows
  • check the -V / --version of each thing as the last step

I also have a High-Availability Proxmox cluster where I can create LXCs within a matter of a few seconds (I could even preallocate some), and delete them just as easily. That could be much faster than GitHub Actions, and give access to any environment... but also comes at the cost of development.

coolaj86 avatar May 16 '24 22:05 coolaj86

This was just a first investigation step. The intention was to expose #814 during build.

Since this workflow was just recently approved I didn't know how long this would take. It also looks like curl needs more permissions, so I'll try to modify it.

Definitely if it takes too long, perhaps there needs to be a different strategy.

virzak avatar May 17 '24 11:05 virzak

After fixing the permission issue, the container seems to be taking about 5-6 seconds. It currently fails because it uses the production webi, which still has the #814 bug, so it needs to be adjusted to use webi produced in this build.

virzak avatar May 17 '24 12:05 virzak

Try installing 7.3 instead of latest / 7.4

coolaj86 avatar May 17 '24 22:05 coolaj86