webhintio.github.io icon indicating copy to clipboard operation
webhintio.github.io copied to clipboard

Add 'upload config file' to home page

Open ststimac opened this issue 7 years ago • 6 comments

Missing the 'upload config file' and 'manual options' links under the search bar.

ststimac avatar May 09 '17 22:05 ststimac

I think we can skip this options for now and bring this feature once we have the recommended configuration working :)

molant avatar May 09 '17 22:05 molant

@molant ok, I'll create a new label for priorities. Mark this one as low.

ststimac avatar May 09 '17 23:05 ststimac

Are you planning to define it in package.json similar to packages configurations or in .sonarwhal, or else on root of the domain?

laukstein avatar Nov 21 '17 19:11 laukstein

Are you planning to define it

@laukstein Sorry, I don't quite understand your question. Can you be more specific? What are you referring to by "it"?

If you are referring to the configurations for the online scanner, we will most probably allow the user to configure things manually, one by one, or upload a JSON file containing the configurations.

If you are referring to were the CLI configurations can reside, they can be in a .sonarwhalrc file in the root of the project, or under sonarwhalConfig in the package.json file.

alrra avatar Nov 22 '17 00:11 alrra

@alrra I meant where and how would look the config file when scanning the online scanner. I think it would benefit if supported configuration located in the scanned domain.

Does config.ts#L33-L38 applies also to online scanner?

laukstein avatar Nov 22 '17 05:11 laukstein

Does config.ts#L33-L38 applies also to online scanner?

No. As previously stated, the online scanner does not yet support configurations.

how would look the config file when scanning the online scanner

"If you are referring to the configurations for the online scanner, we will most probably allow the user to configure things manually, one by one, or upload a JSON file containing the configurations."

alrra avatar Nov 22 '17 07:11 alrra