webhintio.github.io icon indicating copy to clipboard operation
webhintio.github.io copied to clipboard

Search input ARIA role error

Open ststimac opened this issue 8 years ago • 2 comments

In the header of the site we have the 'search documentation' input. When @molant runs the site through Sonar, we're getting a warning that says "Certain ARIA roles must contain particular children"

I don't have a role assigned to that input but a role is being assigned to it after the fact, and I'm assuming this is through however Algolia is configured.

screen shot 2017-06-20 at 9 48 50 am

I believe the role=combobox that is being added to the input is causing the error because this input isn't a combobox, and I believe a role isn't required here but will need to confirm that.

@qzhou1607 I think you researched Algolia, but let me know who I should assign to this if it's not you.

ststimac avatar Jun 20 '17 16:06 ststimac

@ststimac I will take a look again at Algolia's documentation again. I'll remove it if role is not needed.

qzhou1607-zz avatar Jun 20 '17 20:06 qzhou1607-zz

@ststimac @molant It seems that this combobox thing is a false detection in axe-core. See https://github.com/dequelabs/axe-core/issues/160. Unfortunately these accessibility attributes came with Algolia's autocomeplete library and is not configurable. Here is the source code (options contains the data for configuration in Algolia). Any suggestion?

qzhou1607-zz avatar Jun 20 '17 23:06 qzhou1607-zz