hint icon indicating copy to clipboard operation
hint copied to clipboard

https://webhint.io/docs/user-guide/configurations/configuration-development/index.html

Open whiplash696 opened this issue 4 years ago • 5 comments

https://webhint.io/docs/user-guide/configurations/configuration-development/index.html

whiplash696 avatar Jan 29 '21 05:01 whiplash696

Thanks for the report @whiplash696, can you share more detail on what issue(s) you found with the documentation on this page? Thanks!

antross avatar Jan 29 '21 18:01 antross

The list of rules included by the ruleset is incomplete. You have to dig into the source code to find out what you get when you extend from it. This contradicts "The following code snippet is an expanded version of the previous code snippet." and is disappointing.

masi avatar Mar 08 '21 14:03 masi

Good point @masi (and it looks like we'd need to do this for all the configuration docs). I could see fixing this by either including the full JSON or linking to the source on GitHub. What do you think?

The link is definitely the simplest approach to get the current "right" answer, but takes you away from the rest of the docs.

Putting the full JSON inline (along with the current partial snippet) risks getting out-of-sync if we forget to update it. But we could add some build code to copy it from the actual JSON file to avoid that problem.

antross avatar Mar 10 '21 19:03 antross

I agree that copying manually large lists easily ends up being stale. As a quick fix linking to the source files is IMHO good enough.

masi avatar Mar 10 '21 20:03 masi

Thanks @masi!

Would you be interested in opening a PR for this?

This should be the link to replace the expanded code snipped with: https://github.com/webhintio/hint/blob/main/packages/configuration-development/index.json

The markdown for this page lives here: https://github.com/webhintio/hint/blob/main/packages/configuration-development/README.md

sarvaje avatar Mar 12 '21 17:03 sarvaje