drupal-finder icon indicating copy to clipboard operation
drupal-finder copied to clipboard

Published 20 hours ago • verified publisher icon webflo

Use web-root specified for the core's scaffold plugin

Open hussainweb opened this issue 5 years ago • 3 comments

Since the new core scaffold plugin contains a setting for web-root, I think that is the most appropriate setting to determine the path. This PR updates the code to look at that setting first and then the existing approach of installer-paths.

hussainweb avatar Feb 11 '20 00:02 hussainweb

With this, we can close #33.

hussainweb avatar Feb 11 '20 00:02 hussainweb

The errors are again with phpenv with only PHP 5.5. It looks like it has passed for other PHP versions.

hussainweb avatar Feb 11 '20 00:02 hussainweb

The travis errors only happen for PHP 5.5 like written above. Is this unrelated and do we anyway have to check PHP 5.5 anymore for future releases?

As of https://github.com/webflo/drupal-finder/commit/8fc0ece331eb28f663c95d16f66e2cfd3b2d3895 I guess the tests should be re-run`without PHP 5.5?

JPustkuchen avatar Nov 16 '20 16:11 JPustkuchen