drupal-core-require-dev icon indicating copy to clipboard operation
drupal-core-require-dev copied to clipboard

Fix the version of coder module

Open ranqiangjun opened this issue 5 years ago • 3 comments

As title

ranqiangjun avatar Aug 28 '18 14:08 ranqiangjun

Hi @jungleran,

could you explain this change? The version of coder is defined by the drupal/core repository. If you wan't to change the constraint, it should be done in the source repository.

webflo avatar Sep 03 '18 08:09 webflo

Hi, webflo.

Yes, I checked that the drupal/core repository using 8.2.12 as the drupal/coder's version.

But as you know. According to the documentations on drupal.org, https://www.drupal.org/docs/develop/using-composer/using-composer-to-manage-drupal-site-dependencies there is a version mapping during managing a Drupal module using composer.

So for drupal/coder, the version 8.x-2.12 should be mapped to 2.12.

Otherwise, it throws exceptions as following when run composer require --dev webflo/drupal-core-require-dev -vvv against drupal/core:8.6.0-rc1:

    - webflo/drupal-core-require-dev 8.7.x-dev requires drupal/coder ^8.2.12 -> no matching package found.
    - webflo/drupal-core-require-dev 8.6.x-dev requires drupal/coder ^8.2.12 -> no matching package found.
    - webflo/drupal-core-require-dev 8.6.0-rc1 requires drupal/coder ^8.2.12 -> no matching package found.

if you still think that it should be done in the source repository, please close this. Thanks!

ranqiangjun avatar Sep 05 '18 14:09 ranqiangjun

Drupal core's composer.json does not include the Drupal.org package repository, and the 8.3.1 version format is for retrieving from packagist (https://packagist.org/packages/drupal/coder).

composer show -a lists all versions provided by both packagist and the Drupal.org package repository.

$ composer show -a drupal/coder
name     : drupal/coder
descrip. :
keywords :
versions : 8.3.1, 8.3.0, 8.2.12, 8.2.11, 8.2.10, 8.2.9, 8.2.8, 8.2.7, 8.2.6, 8.2.5, 8.2.4, 8.2.3, 8.2.2, 8.2.1, 8.2.0, 8.2.0-rc1, 8.2.0-beta1, 8.2.0-alpha2, 8.2.0-alpha1, 7.2.5, 7.2.4, 7.2.3, 7.2.2, 3.x-dev, 3.1.0, 3.0.0, 2.x-dev, 2.12.0, 2.11.0, 2.10.0, 2.9.0, 2.8.0, 2.7.0, 2.6.0, 2.5.0, 2.4.0, 2.3.0, 2.2.0, 2.1.0, 2.0.0, 2.0.0-rc1, 2.0.0-beta1, 2.0.0-alpha2, 2.0.0-alpha1, dev-8.x-3.x, dev-8.x-2.x, dev-7.x-2.x, dev-3.x, dev-2.x
type     : drupal-module
license  : GNU General Public License v2.0 or later (GPL-2.0-or-later) (OSI approved) https://spdx.org/licenses/GPL-2.0-or-later.html#licenseText
source   : [git] https://git.drupal.org/project/coder 29a25627e7148b3119c84f18e087fc3b8c85b959
dist     : []
names    : drupal/coder

support
source : http://cgit.drupalcode.org/coder

requires
drupal/core ~8.0

requires (dev)
drupal/rules *

gapple avatar Mar 05 '19 19:03 gapple