webex-js-sdk icon indicating copy to clipboard operation
webex-js-sdk copied to clipboard

fix(webex): fix numerous missing awaits in unit tests

Open Coread opened this issue 4 days ago • 2 comments

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

assert.isRejected needs to be awaited/returned in non async tests.

by making the following changes

Fix all the cases where isRejected is not awaited/returned

Change Type

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation update
  • [ ] Tooling change
  • [ ] Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • [ ] I have read and followed contributing guidelines

  • [ ] I discussed changes with code owners prior to submitting this pull request

  • [ ] I have not skipped any automated checks

  • [ ] All existing and new tests passed

  • [ ] I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

Coread avatar Feb 23 '25 11:02 Coread