webex-js-sdk icon indicating copy to clipboard operation
webex-js-sdk copied to clipboard

Published 20 hours ago • verified publisher icon webex

fix: Moderated unmute mode not working when web client is remotely muted

Open marcin-bazyl opened this issue 2 months ago • 2 comments

This is a revert of a PR from a few months ago, because the root cause has been fixed in Locus now (see WEBEX-410234 ), so we can now again rely on the metadata.modifiedBy to ignore Locus DTO updates caused by our own actions.

3 separate scenarios described in these jiras should be working correctly now: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-555818 https://jira-eng-gpk2.cisco.com/jira/browse/WEBEX-382445 https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-583170

TODO: confirm that Locus fix is deployed to prod and then test above scenarios

EDIT: during testing a new Locus issue was found: https://jira-eng-gpk2.cisco.com/jira/browse/WEBEX-415530 we need to wait for it to be fixed

Summary by CodeRabbit

  • New Features

    • Enhanced mute state detection to prevent unnecessary updates when a user mutes themselves.
    • Simplified logic for handling server remote mute updates, ensuring local streams are muted promptly.

  • Bug Fixes

    • Removed outdated test case that incorrectly verified local unmuting behavior on server unmute events.

  • Tests

    • Improved clarity and consistency of test cases for mute state and self utilities, ensuring accurate validation of functionalities.

marcin-bazyl avatar Dec 20 '24 15:12 marcin-bazyl