webex-js-sdk icon indicating copy to clipboard operation
webex-js-sdk copied to clipboard

fix(meetings): empty webrtc dumps when user closes the browser early

Open marcin-bazyl opened this issue 5 months ago • 1 comments

COMPLETES #SPARK-562098

This pull request addresses

When investigating join meeting failure cases where ICE connection was successful, but RTP packets seemed to be not getting through I saw a lot of webrtc dumps that were missing the stats, they only contained the log. It's because SDK uploads the dumps 5s after connection creation and WCME also calls getStats() 5s after connection creation, but it's just after the SDK timer, so the metrics that get uploaded don't have the result of the 1st getStats() call.

by making the following changes

Changed SDK to do the first upload as soon as we get a first stats-report.

Change Type

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation update
  • [ ] Tooling change
  • [ ] Internal code refactor

The following scenarios where tested

unit tests and manual run with the web app

I certified that

  • [x] I have read and followed contributing guidelines

  • [x] I discussed changes with code owners prior to submitting this pull request

  • [x] I have not skipped any automated checks

  • [x] All existing and new tests passed

  • [x] I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

marcin-bazyl avatar Sep 13 '24 15:09 marcin-bazyl