webex-js-sdk icon indicating copy to clipboard operation
webex-js-sdk copied to clipboard

fix(plugin-meetings): added timeout for ICE candidate gathering

Open marcin-bazyl opened this issue 2 years ago • 1 comments

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

I've seen cases where Chrome never called us back with gathering state "complete" or null ice candidate even though we got a lot of (possibly all?) ICE candidates. This fix adds a timeout to ensure we don't get stuck.

by making the following changes

Added a timeout for ICE candidate gathering. After the timer expires, we check if we have enough candidates and continue or fail.

Change Type

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation update
  • [ ] Tooling change
  • [ ] Internal code refactor

The following scenarios where tested

manual tests with sample app, existing automatic tests

I certified that

  • [x] I have read and followed contributing guidelines

  • [x] I discussed changes with code owners prior to submitting this pull request

  • [x] I have not skipped any automated checks

  • [x] All existing and new tests passed

  • [] I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

marcin-bazyl avatar Dec 12 '22 11:12 marcin-bazyl

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2533.d3m3l2kee0btzx.amplifyapp.com