webex-js-sdk icon indicating copy to clipboard operation
webex-js-sdk copied to clipboard

refactor(plugin-meetings): js to ts migration

Open rajeshtezu opened this issue 2 years ago • 4 comments

COMPLETES #<SPARK-376432>

This pull request addresses

  • Migration from Javascript to Typescript
  • Adds any as type where it is not able to infer from code or jsDoc
  • Remaining types will be add manually and types to the function params also need some refactoring e.g. converting the raw types to interfaces, which we will do gradually.

by making the following changes

  • Renames all the files except root index.js file inside plugin-meetings to .ts files and add types.

Change Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation update
  • [ ] Tooling change
  • [x] Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • [ ] I have read and followed contributing guidelines

  • [ ] I discussed changes with code owners prior to submitting this pull request

  • [ ] I have not skipped any automated checks

  • [ ] All existing and new tests passed

  • [ ] I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

rajeshtezu avatar Nov 18 '22 07:11 rajeshtezu

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2508.d3m3l2kee0btzx.amplifyapp.com

what about test files? are they omitted purpose?

marcin-bazyl avatar Nov 18 '22 13:11 marcin-bazyl

what about test files? are they omitted purpose?

Yes Marcin, we didn't include test files as the number of files getting affected is already too high. Will raise a separate PR for test files.

rajeshtezu avatar Nov 23 '22 08:11 rajeshtezu

@marcin-bazyl @arun3528 I have removed all the formatting. Please review.

rajeshtezu avatar Nov 25 '22 13:11 rajeshtezu

All occurrences of // @ts-nocheck have been removed.

rajeshtezu avatar Dec 15 '22 05:12 rajeshtezu