webex-js-sdk icon indicating copy to clipboard operation
webex-js-sdk copied to clipboard

feat(internal-plugin-encryption): add methods for Bring Your Own Master Key feature

Open yahcheng opened this issue 2 years ago • 2 comments

add methods which will be used by Control Hub for Bring Your Own Master Key feature. This is the related wiki and ux and jira

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE >

by making the following changes

< DESCRIBE YOUR CHANGES >

  1. add method to download public key;
  2. add method to upload master key;
  3. add method to activate master key;
  4. add method to get all master keys;
  5. delete one master key;

Change Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation update
  • [ ] Tooling change
  • [ ] Internal code refactor

The following scenarios where tested

add integration tests to cover the whole flow: get public key and then upload master key and then get all master keys and then activate the uploaded master and then delete the master key.

I certified that

  • [ ] I have read and followed contributing guidelines

  • [ ] I discussed changes with code owners prior to submitting this pull request

  • [ ] I have not skipped any automated checks

  • [ ] All existing and new tests passed

  • [ ] I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

yahcheng avatar Apr 08 '22 03:04 yahcheng

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2320.d3m3l2kee0btzx.amplifyapp.com

Any update on this ?

arun3528 avatar Sep 02 '22 15:09 arun3528

Closing this branch as there has been no activity for over 1.5 years.

sreenara avatar Jun 19 '24 05:06 sreenara