webex-js-sdk icon indicating copy to clipboard operation
webex-js-sdk copied to clipboard

Support for cross-region boards

Open pcl opened this issue 4 years ago • 8 comments

Currently, webex-js-sdk doesn't properly support cross-region boards. Let's fix that.

Most recently, this manifests in realtime.js:115, which does not propagate the board channel URL (and thus the board channel cluster) to the board registration call, resulting in an attempted registration in the wrong cluster.

https://github.com/webex/webex-js-sdk/blob/097f11497e6befaf7da918ebe925b8be8172ad8c/packages/node_modules/%40webex/internal-plugin-board/src/realtime.js#L97

pcl avatar Aug 23 '21 09:08 pcl

@pcl can you please provide some more details and concrete examples about this issue showing the expected and actual cluster? Can you also share the board channel URL you mentioned? Any steps we can use to reproduce this? I assume it is reproducible with the https://js.samples.s4d.io/browser-plugin-meetings/ demo here, but can you confirm?

jbenyovs avatar Aug 23 '21 12:08 jbenyovs

I haven't tried to reproduce the bug in your sample app, but it's probably reproducible there.

Here are two different board URLs:

https://board-a.wbx2.com/board/api/v1/channels/16321ab0-00d1-11ec-bca4-e56fcbadda24 https://board-k.wbx2.com/board/api/v1/channels/3e9e50a0-ff63-11eb-b573-eda7098f33a9

A user homed in cluster a will not be able to call register() on the board-k URL, since the registration has to happen against board-k.wbx2.com.

pcl avatar Aug 24 '21 09:08 pcl

Also, fyi, the API call you're using has been deprecated. I had the board team turn it back on, so that at least the client sorta works, but you should not expect this API to be around forever.

https://sqbu-github.cisco.com/WebExSquared/board/blob/master/server/src/main/java/com/cisco/wx2/board/server/BoardController.java#L81

pcl avatar Aug 24 '21 09:08 pcl

@pcl thanks, I have reached out to engineering to check your commit and reply to this.

jbenyovs avatar Aug 24 '21 12:08 jbenyovs

Great, thanks.

I see that some checks failed, but I can't see why. Can you post details here? I don't intend to give CircleCI access to my private repositories...

pcl avatar Aug 24 '21 13:08 pcl

Oh and also -- the changes in the related PR are working great in our downstream codebase.

pcl avatar Aug 24 '21 13:08 pcl

@pcl we received a feedback from engineering management and according to them this is not a bug, it's an enhancement request. Additionally, board plugin is internal and only meant to be used by the web app team.

jbenyovs avatar Feb 11 '22 15:02 jbenyovs

Ok cool. Be sure to let engineering management know about the bug in the web client, and please send me the jira for the corresponding filed bug.

On Fri, Feb 11, 2022 at 07:23 jbenyovs @.***> wrote:

@pcl https://github.com/pcl we received a feedback from engineering management and according to them this is not a bug, it's an enhancement request. Additionally, board plugin is internal and only meant to be used by the web app team.

— Reply to this email directly, view it on GitHub https://github.com/webex/webex-js-sdk/issues/2155#issuecomment-1036328139, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAICPQVAAK2KV24UNWSSDDU2USY7ANCNFSM5CUFMGFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

pcl avatar Feb 11 '22 16:02 pcl