webdriverio icon indicating copy to clipboard operation
webdriverio copied to clipboard

Add resignApp capability type

Open dprevost-LMI opened this issue 9 months ago • 6 comments

Proposed changes

Add resignApp capability type

We need to use this capability, but we stumble into typing issues.

Types of changes

  • [x] Polish (an improvement for an existing feature)
  • [x] Bugfix (non-breaking change which fixes an issue)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (N/A)

Backport Request

  • [x] Back-ported PR : https://github.com/webdriverio/webdriverio/pull/12851#issue-2288639253

Reviewers: @webdriverio/project-committers

dprevost-LMI avatar May 08 '24 16:05 dprevost-LMI

@dprevost-LMI thanks for the contribution, mind signing the CLA?

christian-bromann avatar May 08 '24 16:05 christian-bromann

@dprevost-LMI thanks for the contribution, mind signing the CLA?

@christian-bromann, Done! That was a learning path...

dprevost-LMI avatar May 09 '24 20:05 dprevost-LMI

  • Back-ported PR at #XXXXX (in progress)

The main branch is currently for v9 development if you are interested having this backported to v8, mind raising the same pr for the v8 branch?

christian-bromann avatar May 09 '24 21:05 christian-bromann

  • Back-ported PR at #XXXXX (in progress)

The main branch is currently for v9 development if you are interested having this backported to v8, mind raising the same pr for the v8 branch?

Will do, I was waiting for the merge to cherry pick the main commit but I can also open a PR with the same commit

dprevost-LMI avatar May 09 '24 21:05 dprevost-LMI

See https://github.com/webdriverio/webdriverio/pull/12851#issue-2288639253 for the v8 PR

dprevost-LMI avatar May 09 '24 23:05 dprevost-LMI

Hey dprevost-LMI 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day, The WebdriverIO Team 🤖

wdio-bot avatar May 10 '24 04:05 wdio-bot