selenium-standalone icon indicating copy to clipboard operation
selenium-standalone copied to clipboard

chore(deps): Replace unmaintained npm-run-all with npm-run-all2

Open seanpoulter opened this issue 10 months ago • 4 comments

Proposed Changes

This PR builds on https://github.com/webdriverio/webdriverio/pull/12628:

I noticed that this project is using npm-run-all still and not the maintained fork npm-run-all2. Here's a PR that fixes that.

seanpoulter avatar Apr 18 '24 03:04 seanpoulter

Mhm 🤔 it seems like this repository doesn't like this upgrade:

/home/runner/work/selenium-standalone/selenium-standalone/node_modules/npm-run-all2/node_modules/minimatch/dist/commonjs/ast.js:86
    #fillNegs() {
             ^

SyntaxError: Unexpected token '('

christian-bromann avatar Apr 18 '24 15:04 christian-bromann

Ah, yea, Node.js v12 and v14 don't have support for private methods with a #.

It's runs with v12 because that's what is in "engines". Can we drop support for everything outside of the maintenance period? The release docs say that'd be >=18.

seanpoulter avatar Apr 18 '24 16:04 seanpoulter

Can we drop support for everything outside of the maintenance period? The release docs say that'd be >=18.

Yes, but this would require a new major semver release.

christian-bromann avatar Apr 18 '24 17:04 christian-bromann

That's a good point Christian. I'll set this up so we can build with the LTS and the target Node 12.

seanpoulter avatar Apr 20 '24 18:04 seanpoulter