selenium-standalone
selenium-standalone copied to clipboard
chore(deps): Replace unmaintained npm-run-all with npm-run-all2
Proposed Changes
This PR builds on https://github.com/webdriverio/webdriverio/pull/12628:
I noticed that this project is using
npm-run-all
still and not the maintained forknpm-run-all2
. Here's a PR that fixes that.
Mhm 🤔 it seems like this repository doesn't like this upgrade:
/home/runner/work/selenium-standalone/selenium-standalone/node_modules/npm-run-all2/node_modules/minimatch/dist/commonjs/ast.js:86
#fillNegs() {
^
SyntaxError: Unexpected token '('
Ah, yea, Node.js v12 and v14 don't have support for private methods with a #
.
It's runs with v12 because that's what is in "engines"
. Can we drop support for everything outside of the maintenance period? The release docs say that'd be >=18
.
Can we drop support for everything outside of the maintenance period? The release docs say that'd be
>=18
.
Yes, but this would require a new major semver release.
That's a good point Christian. I'll set this up so we can build with the LTS and the target Node 12.