selenium-standalone icon indicating copy to clipboard operation
selenium-standalone copied to clipboard

chore/update code format, replace declaration with expressions

Open potapovDim opened this issue 1 year ago • 5 comments

Updated code format second iteration

potapovDim avatar Sep 18 '23 11:09 potapovDim

Hi @potapovDim I am just curious about why did you do that ? What's wrong with function declaration?

udarrr avatar Sep 19 '23 06:09 udarrr

@udarrr nothing wrong with fn declaration, just to have a common code approach format across library i started to update it to expression format also expression could not be hosted in a way as declarations so better for reading, would be also good to add jsdoc comments and some lint format/prettier

potapovDim avatar Sep 19 '23 11:09 potapovDim

@potapovDim maybe it makes sense to introduce Prettier or EsLint to ensure that the next contributor doesn't switch this around again. I don't mind which code style we go with as long as we ensure we stick with it using these tools.

christian-bromann avatar Sep 19 '23 16:09 christian-bromann

@christian-bromann i can do that, can we merge this one and i will proceed with that next steps ? or do you want me to add this one as a part current PR ? i would also want to have pre - commit hook with lint and unit tests if it sounds suitable ?

potapovDim avatar Sep 20 '23 09:09 potapovDim

or do you want me to add this one as a part current PR ?

Let's add it to this PR if you don't mind

christian-bromann avatar Sep 21 '23 20:09 christian-bromann