selenium-standalone icon indicating copy to clipboard operation
selenium-standalone copied to clipboard

Published 20 hours ago • verified publisher icon webdriverio

fixed args prefix for selenium3

Open ArminazK opened this issue 2 years ago • 3 comments

fixes #616

ArminazK avatar Apr 06 '22 06:04 ArminazK

Can we make sure to have a test for this? I wonder if it makes sense to add an e2e test suite to ensure that the whole process works.

Hi, I was thinking about e2e tests. Seems that current tests target selenium 4 since version 8>. In that case we need to have 2 tracks of tests (I mean not only for '--port' argument) ... This PR change works now on both versions and does not break existing tests.

ArminazK avatar Apr 06 '22 08:04 ArminazK

@ArminazK cheers! There seems to be a couple of broken tests in CI. Can you take a look?

christian-bromann avatar Apr 20 '22 04:04 christian-bromann

@ArminazK ping

christian-bromann avatar Jul 08 '22 17:07 christian-bromann

CLA Missing ID CLA Not Signed

  • :white_check_mark: login: ArminazK / name: ArminazK (53452fff2cd21821f090db33d208dccdd272fb47, a0938fa777e9b1570d6e78cd05f80fcf490fdb22, f0a9da391e59b76cc3609fd9120f5d3ddae8fe94, a11e7f841f2bbaa8acd5d7fd1462a7cf61b8efad, c73d93efb88826ca6d971f932a6bd51789e1f570)
  • :x: The commit (e036c9228bfb6f024c36422845f2bf08ab0e1121). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

linux-foundation-easycla[bot] avatar Oct 19 '22 10:10 linux-foundation-easycla[bot]