expect-webdriverio icon indicating copy to clipboard operation
expect-webdriverio copied to clipboard

Support for Multiremote and fixed many errors of current main branch

Open SnakeDrak opened this issue 3 years ago • 6 comments

I have added support for multiremote and custom driver when we use the elements or mock matchers. Also I have added some fixes for the current main branch, however the npm run test:types is causing issues yet due to external library types. I will fix them in another PR.

It should fix or use as workaround for issue 106.

UPDATED: Types fixed as well.

SnakeDrak avatar Nov 19 '21 16:11 SnakeDrak

CLA Not Signed

CLA Not Signed

Also can you explain how this patch will enable multiremote to work?

christian-bromann avatar Mar 10 '22 09:03 christian-bromann

@christian-bromann I did it some month ago and I don't remember the full details. However, the original idea was to be able to pass the driver where you want to check. You could use something like:

expect(myInput).toHaveAttribute('class', 'form-control', browser)
expect(myInput).toHaveAttribute('class', 'md-form-control', app)

I remember the master branch was broken and I tried to fix it as well, for that reason you see some extra commits. At this moment, I am using my fork with this feature to support multiples driver at the same instance and to be able to test correctly each one.

You can check the tests included to know if it has a sense for you. Most probably I would have to update against master again.

SnakeDrak avatar Mar 31 '22 22:03 SnakeDrak

@SnakeDrak is there any interest to push this PR forward?

christian-bromann avatar May 12 '22 20:05 christian-bromann

Is there anything I can do to help pushing this forward? I would like to see the multiremote feature land in expect-webdriverio.

pwespi avatar Jun 24 '22 13:06 pwespi

Any news?

lacell75 avatar Jan 24 '23 16:01 lacell75

@lacell75 as you can see, no. Would you like to pick this up?

christian-bromann avatar Jan 24 '23 17:01 christian-bromann

I will go ahead and close this as the branch starts to diverge to much from main. I would be happy for any contributions making this library compatible with multiremote.

Thanks for the work you put into this @SnakeDrak

christian-bromann avatar Jul 15 '23 21:07 christian-bromann