TYPO3-metaseo icon indicating copy to clipboard operation
TYPO3-metaseo copied to clipboard

Add TYPO3 8 compatible FlashMessage Rendering in update script

Open ipf opened this issue 8 years ago • 8 comments

This fixes the issue, that executing the updater script in the TYPO3 8 backend results in a fatal error, because the FlashMessage handling has been changed.

ipf avatar Sep 01 '17 07:09 ipf

thanks a lot

thomaszbz avatar Sep 01 '17 07:09 thomaszbz

@ipf which version were you coming from? 1.0.x?

thomaszbz avatar Sep 01 '17 08:09 thomaszbz

Just installed it in 3.0.0 and tried to run the updater script that failed. So not really coming from a version, but a clean install and was curious what happened when I push the button in the EM.

ipf avatar Sep 01 '17 08:09 ipf

@ipf Funny. We've seen more than 800 downloads of 3.0.0 now (together with Packagist), and you're reporting the first bug which is 3.0.0 specifc.

Thanks for catching this!

thomaszbz avatar Sep 01 '17 08:09 thomaszbz

@ipf Please post your exact TYPO3 version and PHP version in #502.

If you find a documented breaking change somewhere, that would be of help, too.

thomaszbz avatar Sep 01 '17 09:09 thomaszbz

Hmm, is there a plan to merge this pr?

nostadt avatar Oct 23 '17 16:10 nostadt

@AMartinNo1 It will be part of the next release. For metaseo 3.0.0 nobody needs to execute the update script: Fresh installs don't need to update the schema. And upgraders also don't have to run it as long as they come from 2.1.0 (and even back to 2.0.0). Should not be urgent, or is it?

Eventually, the schema update even runs, just the flash message fails.

thomaszbz avatar Oct 23 '17 16:10 thomaszbz

I see. Alright, I was just curious as the milestone is set to 1st Sep. 2017 and we experience some issues. The update script was one possible solution - it did not fix our main issue.

nostadt avatar Oct 23 '17 16:10 nostadt