Dockerfile icon indicating copy to clipboard operation
Dockerfile copied to clipboard

File `98-webdevops.ini` contains deprecated Xdebug directives

Open stekostas opened this issue 4 years ago • 8 comments
trafficstars

The PHP .ini file /usr/local/etc/php/conf.d/98-webdevops.ini in the webdevops/php-nginx-dev:7.4 image sets the deprecated Xdebug directives xdebug.output_dir, xdebug.remote_connect_back, and xdebug.remote_enable which results in log messages such as:

Xdebug: [Config] The setting 'xdebug.profiler_output_dir' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.profiler_output_dir (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_connect_back' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_connect_back (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_enable' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_enable (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)

stekostas avatar Dec 16 '20 09:12 stekostas

This is for compatibility reasons. We still build old images like 7.0, 7.1 etc. which don't contain xdebug 3. So we need both configurations as we don't have a switch yet for providing different xdebug configs per image.

htuscher avatar Dec 17 '20 11:12 htuscher

Thank you for the explanation @hhoechtl. I see that there's already a PR (#386) from @kaluzki (thank you!) fixing this issue, so I'm going to keep an eye on it.

stekostas avatar Dec 18 '20 09:12 stekostas

can't it be fixed by removing the deprecated flags in https://github.com/webdevops/Dockerfile/blob/master/docker/php-dev/8.0/conf/provision/bootstrap.d/20-php-module-xdebug.sh

ruedigerm-playster avatar Aug 20 '21 16:08 ruedigerm-playster

If anyone is looking for a simple workaround in the meantime:

https://github.com/codenamephp/docker.php.webdevops.php-dev/blob/d040f0452499bc4ae38fc9e05d674f57b368488c/Dockerfile#L8

RUN sed -i '/xdebug.\(remote_\|profiler_output_dir\)/d' /opt/docker/etc/php/php.webdevops.ini

This just removes the deprecated settings using sed.

bastianschwarz avatar Aug 20 '21 17:08 bastianschwarz

This issue is trickier than it seems at first sight. It prevents PHPStorm to correctly identify test frameworks (such as PHPUnit and Codeception).

giacmir avatar Sep 07 '21 13:09 giacmir

Is there any update on this? Seems the pr stuck since may this year

Atomzwieback avatar Oct 11 '21 08:10 Atomzwieback

It's just lack of time on my side.

Am Mo., 11. Okt. 2021 um 10:38 Uhr schrieb Atomzwieback < @.***>:

Is there any update on this? Seems the pr stuck since may this year

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/webdevops/Dockerfile/issues/384#issuecomment-939813100, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGXLBHH3FNL3NGQHVDEMYTUGKPA5ANCNFSM4U5U2PXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Onedrop GmbH & Co. KG

Dr.-Leo-Ritter-Str. 2 93049 Regensburg

Tel. +49 (0) 941 / 206 064 - 40

1drop.de @.*** @.***>

http://www.facebook.com/onedropsolutions http://twitter.com/1drop

htuscher avatar Oct 11 '21 08:10 htuscher

@hhoechtl am im able to help to proceed this?

Atomzwieback avatar Oct 11 '21 09:10 Atomzwieback