motion-sparkle icon indicating copy to clipboard operation
motion-sparkle copied to clipboard

Published 20 hours ago • verified publisher icon webcracy

Create the resources dir if it doesn't exist

Open lloydpick opened this issue 10 years ago • 6 comments

And just re-use the helper method for the sparkle config dir

lloydpick avatar Nov 30 '14 13:11 lloydpick

Thanks @lloydpick!

I assumed the resources/ folder was part of the default template; is my assumption bust?

I'll review this PR to see if I can refactor some of this config stuff, then I'll pull your fix in.

Cheers

webcracy avatar Nov 30 '14 15:11 webcracy

My project didn't start from the default template, so I didn't have one, which meant it failed to write the public key, it just happily carried on going.

lloydpick avatar Nov 30 '14 16:11 lloydpick

Got it, thanks for the info! I'll update the issue after my review.

webcracy avatar Nov 30 '14 17:11 webcracy

Hi @webcracy is this PR, about a missing resources folder good to merge?

YesThatAllen avatar Oct 19 '15 07:10 YesThatAllen

@YesThatAllen Is this problem affecting you at the moment? This PR should work according to my review, but I didn't want to merge it "as is" for a reason I don't recall right now. I was going to change it a bit, but haven't yet.

webcracy avatar Oct 21 '15 11:10 webcracy

The fix is working for us, yes. Thanks.

YesThatAllen avatar Oct 21 '15 14:10 YesThatAllen