react-integration icon indicating copy to clipboard operation
react-integration copied to clipboard

Published 20 hours ago • verified publisher icon webcomponents

Reactify not working in latest Chrome version

Open kentendo opened this issue 8 years ago • 6 comments

@treshugart Reactified component is rendering in Firefox, but not in latest Chrome (55.0.2883.95). Component gets inserted inserted into DOM but is never upgraded and never renders itself.

See codepen below... http://codepen.io/kentendo/pen/BQMEbe?editors=1010

kentendo avatar Dec 20 '16 02:12 kentendo

I only see this happening in Chrome version 55.* Works in 56.

kentendo avatar Dec 20 '16 17:12 kentendo

@kentendo do you have a reproduction of this? If you can write a failing test for this, that would be awesome :). Currently tests pass in 55.

treshugart avatar Dec 21 '16 09:12 treshugart

I started on a test, but looked at the other tests in here and noticed they are still using the v0 API. The issue I'm seeing is more v1 specific, where the lifecycle hooks ( onConnectedCallback, etc ) are never getting called. Any ideas?

kentendo avatar Dec 21 '16 23:12 kentendo

You're right. We should update the tests, for sure. I raised #59 for this. I don't have much time to do this for the next week or so. Would you have time to submit a PR for it? I understand if not.

treshugart avatar Dec 21 '16 23:12 treshugart

I'll give it a shot...

kentendo avatar Dec 22 '16 00:12 kentendo

I've made some good progress on #59, but I'm having issues with the event tests in chrome... https://github.com/kentendo/react-integration

kentendo avatar Dec 22 '16 23:12 kentendo