polyfills
polyfills copied to clipboard
Fix issue #180: Add code to make sure the internal `inertDoc` has the…
… same domain as the real document
object to avoid WrongDocumentError
when setting innerHTML
in IE11.
Reference Issue
Fixes #180
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
The current fix works, but only when document.domain
is defined before the webcomponentsjs bundle is loaded. Possibly inertDoc
's domain should be updated in set innerHTML
instead (or in addition)?
I wasn't sure whether the check was needed with each call, but that sounds a bit more resilient. I'll give this a try.
Hello! @jason0x43 @kurtinatlanta I am running into the same issue as #180. When will this PR get merged?
Adding @azakus @sorvell
And released please, eg https://cdn.jsdelivr.net/npm/@webcomponents/[email protected]/webcomponents-loader.js
So that we can get it the way we used to before.
This would be super helpful! We have a lot of pages setting document.domain
to support iFrames, but we are also trying to add support for the webcomponent implementation of our company's design system.
Is there anything needed to help push this along?
@kurtinatlanta I'm a bit unfamiliar with the area of the code, but at it'd be nice to have a test that fails currently on IE11 and passes after this change.
Any idea when this fix is going to be in? This is something we are also struggling with.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.