polyfills icon indicating copy to clipboard operation
polyfills copied to clipboard

Fix issue #180: Add code to make sure the internal `inertDoc` has the…

Open kurtinatlanta opened this issue 5 years ago • 13 comments

… same domain as the real document object to avoid WrongDocumentError when setting innerHTML in IE11.

Reference Issue

Fixes #180

kurtinatlanta avatar Jul 30 '19 19:07 kurtinatlanta

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jul 30 '19 19:07 googlebot

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jul 30 '19 19:07 googlebot

@googlebot I signed it!

kurtinatlanta avatar Jul 30 '19 19:07 kurtinatlanta

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Jul 30 '19 19:07 googlebot

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Jul 30 '19 19:07 googlebot

The current fix works, but only when document.domain is defined before the webcomponentsjs bundle is loaded. Possibly inertDoc's domain should be updated in set innerHTML instead (or in addition)?

jason0x43 avatar Jul 30 '19 21:07 jason0x43

I wasn't sure whether the check was needed with each call, but that sounds a bit more resilient. I'll give this a try.

kurtinatlanta avatar Jul 31 '19 01:07 kurtinatlanta

Hello! @jason0x43 @kurtinatlanta I am running into the same issue as #180. When will this PR get merged?

Adding @azakus @sorvell

janabimustafa avatar Dec 16 '19 23:12 janabimustafa

And released please, eg https://cdn.jsdelivr.net/npm/@webcomponents/[email protected]/webcomponents-loader.js

So that we can get it the way we used to before.

cekvenich avatar Dec 16 '19 23:12 cekvenich

This would be super helpful! We have a lot of pages setting document.domain to support iFrames, but we are also trying to add support for the webcomponent implementation of our company's design system.

Is there anything needed to help push this along?

znewton avatar Dec 18 '19 00:12 znewton

@kurtinatlanta I'm a bit unfamiliar with the area of the code, but at it'd be nice to have a test that fails currently on IE11 and passes after this change.

justinfagnani avatar Dec 18 '19 20:12 justinfagnani

Any idea when this fix is going to be in? This is something we are also struggling with.

piyushsh avatar Oct 29 '20 13:10 piyushsh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 30 '21 05:10 stale[bot]