custom-elements-everywhere icon indicating copy to clipboard operation
custom-elements-everywhere copied to clipboard

Upgrading Elements

Open jthoms1 opened this issue 7 years ago • 3 comments

Should there be a test that covers upgrading elements? Just wondering if the custom element is defined after the framework/library renders the output how

It appears that this currently does not work for Preact props and might be an issue for others.

jthoms1 avatar Oct 03 '17 01:10 jthoms1

I started to write tests for that here: https://github.com/webcomponents/custom-elements-everywhere/blob/master/libraries/react/src/component-tests.js#L134

We could totally check this to see what they do if the property is undefined on the element.

robdodson avatar Oct 05 '17 03:10 robdodson

Adding some additional context to this (very old) thread. https://github.com/webcomponents/custom-elements-everywhere/blob/master/libraries/react/src/basic-tests.js#L129-L133

robdodson avatar Jan 05 '19 21:01 robdodson

This is definitely a scenario that needs testing. We might add this into a 2.0 version of the score?

rictic avatar Dec 29 '21 18:12 rictic