custom-elements-everywhere icon indicating copy to clipboard operation
custom-elements-everywhere copied to clipboard

Udating svelte version to 4.2.2

Open OvidijusParsiunas opened this issue 2 years ago • 2 comments

OvidijusParsiunas avatar Oct 20 '23 15:10 OvidijusParsiunas

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 20 '23 15:10 google-cla[bot]

Svelte has recently published version 4.2.2 which fixes a camel case naming convention issue for properties. This PR version updates the Svelte version used within this repo to run the web component tests against it.

I am aware that there is another PR out there that updates some of Svelte tests, so if this PR overcomplicates things I am ok if it is declined.

OvidijusParsiunas avatar Oct 20 '23 15:10 OvidijusParsiunas

@rictic Could you please look at this PR to update the Svelte version and approve? If CLA is a problem, please consider approving https://github.com/webcomponents/custom-elements-everywhere/pull/2296

nileshtrivedi avatar Jul 08 '24 05:07 nileshtrivedi

Sorry for the delay, this needed to update the expectations too. Fixed in #2369

rictic avatar Jul 12 '24 23:07 rictic