dynmap icon indicating copy to clipboard operation
dynmap copied to clipboard

Bump minimum spigot version, improve armor points counting

Open stepech opened this issue 3 years ago • 1 comments
trafficstars

I've noticed that armor points seem to be counted weirdly by dynmap:

dynmap original full netherite dynmap original, netherite and elytra

I would expect parity with minecraft client, which doesn't seem to be here. This PR bumps minimum spigot version to 1.10.2 (which is also minimum version officialy supported) from 1.7.10. It also uses new API method introduced in 1.9, that gets precise armor points from bukkit api.

New:

dynmap new full netherite dynmap new netherite and elytra

Now to be clear.. There was some weird math going on in Armor.java, so I might be touching something I don't understand, but this just seem right, as those past results were unexpected.


I also updated SkinsRestorer to check for compatibility issues and to keep dynmap up to date.

stepech avatar Aug 08 '22 20:08 stepech

Old method to get armor durability was also deprecated in 1.13.

stepech avatar Aug 08 '22 21:08 stepech

Thanks!

mikeprimm avatar Aug 14 '22 04:08 mikeprimm