dynmap icon indicating copy to clipboard operation
dynmap copied to clipboard

Sign generated markers are not removed from the map when the sign is destroyed.

Open omega489 opened this issue 5 years ago • 3 comments

Server Information

  • [x] Latest Bukkit Plugin
    • Version: v3.0-beta-3
  • [ ] Latest Forge Mod
    • Version:
  • I can reproduce this issue consistently
    • [x] In Multiplayer
    • [ ] After deleting/renaming the DYNMAP folder
  • [x] I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I'm having the same problem.
  • [ ] I am crashing and can provide my crash report(s)
  • I have tried the following diagnostics;
    • [x] Re-rendered missing chunks using /dynmap fullrender
    • [ ] Cleared cached tiles using /dynmap purgeworld [world] (especially if using a map from an older version)
    • [ ] Deleted/Renamed the dynmap folder to regenerate configs and files fresh
    • [ ] Tested using the 'HEAD' version from dynmap.us/builds (these are stable to use)
    • [ ] Rechecked the Minecraft Server and Webserver Config (If using an external Webserver)

Issue Description

Creating a marker using a sign. marker can be created fine, but the marker is not removed when the sign is destroyed.

According to the wiki "If the sign is later deleted, the corresponding map marker is deleted." markers should be destroyed when the corresponding sign is destroyed?

Reproduce Steps

  1. The user places a sign with [dynmap] on the first line and sign text.
  2. Marker is generated on the map.
  3. The user destroys the signpost in game.
  4. Marker persists on the map. ...

Additional Information

omega489 avatar Apr 28 '19 22:04 omega489

On our server we've found that markers placed using signs are removed quickly as expected when the sign is destroyed - unless the label contains an apostrophe! It might be the case for other non-A-Z characters too?

Cassolotl avatar Nov 23 '19 13:11 Cassolotl

@omega489 @Cassolotl this case https://github.com/webbukkit/dynmap/issues/2288 was looking into apostophes and html-special characters. Would you have time to check out the big-ish release in 3.3 or snapshots and give it a go and confirm?

generrosity avatar Feb 22 '22 11:02 generrosity

this is still the case in dynmap 3.4-beta-5 with paper 1.19.2

JurgenKuyper avatar Aug 11 '22 12:08 JurgenKuyper