dkg-substrate
dkg-substrate copied to clipboard
Remove all ensure_root and replace with EnsureOrigin<> #2
Summary of changes Changes introduced in this pull request:
- Replace ensure_root with ensure_origin
Reference issue to close (if applicable)
https://github.com/webb-tools/dkg-substrate/issues/441
Codecov Report
Base: 21.20% // Head: 18.70% // Decreases project coverage by -2.51%
:warning:
Coverage data is based on head (
3f581e5
) compared to base (792d045
). Patch coverage: 25.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
- Coverage 21.20% 18.70% -2.50%
==========================================
Files 66 68 +2
Lines 4109 4745 +636
==========================================
+ Hits 871 887 +16
- Misses 3238 3858 +620
Impacted Files | Coverage Δ | |
---|---|---|
pallets/dkg-metadata/src/lib.rs | 16.96% <14.29%> (ø) |
|
pallets/dkg-proposal-handler/src/lib.rs | 54.45% <100.00%> (ø) |
|
dkg-gadget/src/lib.rs | 0.00% <0.00%> (ø) |
|
dkg-gadget/src/worker.rs | 0.00% <0.00%> (ø) |
|
dkg-primitives/src/types.rs | 0.00% <0.00%> (ø) |
|
dkg-gadget/src/async_protocols/mod.rs | 0.00% <0.00%> (ø) |
|
dkg-gadget/src/async_protocols/keygen/handler.rs | 0.00% <0.00%> (ø) |
|
...kg-gadget/src/gossip_messages/public_key_gossip.rs | 0.00% <0.00%> (ø) |
|
...gadget/src/async_protocols/blockchain_interface.rs | 0.00% <0.00%> (ø) |
|
dkg-gadget/src/db/offchain_storage.rs | 0.00% <0.00%> (ø) |
|
... and 2 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@dutterbutter @drewstone Can you please review this?
Can you fix the lint?
Also why are the types all called AssetModifierOrigin when some pallets have nothing to do with assets?
Is this still active @herou? I will close next week without comment.
Closing this since it's gone inactive.
@drewstone sorry for not responding to you on time. I was on vacation. Can you reopen this PR?
Reopened @herou